Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTG-1151] using the last seen finalized slot to distinguish between the final data #397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[MTG-1151] using the last seen finalized slot to distinguish between the final data #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
071f222
using the last seen finalized slot to distinguish between the final data
StanChe Jan 30, 2025
61e8377
changed the test
StanChe Jan 30, 2025
37d5f1a
fmt
StanChe Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rocks-db/src/clients/asset_streaming_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async fn get_complete_asset_details(
.get(url.clone().value)?
.map(Into::into);
let cutoff_slot = Storage::column::<ParameterColumn<u64>>(backend.clone(), metrics.clone())
.get(Parameter::TopSeenSlot)?
.get(Parameter::LastBackfilledSlot)?
.flatten()
.unwrap_or_default()
.wrapping_sub(OFFSET_SLOTS);
Expand Down
2 changes: 1 addition & 1 deletion rocks-db/src/sequence_consistent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ impl SequenceConsistentManager for Storage {
#[async_trait]
impl LastProcessedSlotGetter for Storage {
async fn get_last_ingested_slot(&self) -> Result<Option<u64>, interface::error::StorageError> {
self.get_parameter::<u64>(crate::parameters::Parameter::TopSeenSlot)
self.get_parameter::<u64>(crate::parameters::Parameter::LastBackfilledSlot)
.await
.map_err(|e| e.into())
}
Expand Down
15 changes: 12 additions & 3 deletions rocks-db/tests/parameters_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,27 @@ mod tests {
assert!(response == None);

let last_seen_slot = 242827927u64;
storage.merge_top_parameter::<u64>(Parameter::TopSeenSlot, last_seen_slot).await.unwrap();
storage
.merge_top_parameter::<u64>(Parameter::LastBackfilledSlot, last_seen_slot)
.await
.unwrap();
let response = storage.get_last_ingested_slot().await.unwrap();

assert!(response == Some(last_seen_slot));

let some_old_slot = 137_827_927u64;
storage.merge_top_parameter::<u64>(Parameter::TopSeenSlot, some_old_slot).await.unwrap();
storage
.merge_top_parameter::<u64>(Parameter::LastBackfilledSlot, some_old_slot)
.await
.unwrap();
let response = storage.get_last_ingested_slot().await.unwrap();
assert!(response == Some(last_seen_slot));

let some_new_slot = 243_827_927u64;
storage.merge_top_parameter::<u64>(Parameter::TopSeenSlot, some_new_slot).await.unwrap();
storage
.merge_top_parameter::<u64>(Parameter::LastBackfilledSlot, some_new_slot)
.await
.unwrap();
let response = storage.get_last_ingested_slot().await.unwrap();
assert!(response == Some(some_new_slot));
}
Expand Down
Loading