Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTG-1029 write tests on determining non-fungible token type by token … #395

Merged
merged 2 commits into from
Jan 30, 2025
Merged

MTG-1029 write tests on determining non-fungible token type by token … #395

merged 2 commits into from
Jan 30, 2025

Conversation

andrii-kl
Copy link
Contributor

…supply and decimals options.

@andrii-kl andrii-kl self-assigned this Jan 29, 2025
armyhaylenko
armyhaylenko approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@armyhaylenko armyhaylenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LBTM, though it seems that we just can't merge it unless the todos are fixed

kstepanovdev
kstepanovdev approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@kstepanovdev kstepanovdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I agree with Alex regarding todos

@andrii-kl
Copy link
Contributor Author

andrii-kl commented Jan 30, 2025 •
edited
Loading

generally LBTM, though it seems that we just can't merge it unless the todos are fixed

These errors are out of scope of this task. It's a new bugs I have created a new tickets to fix them with links on this tests.

@andrii-kl andrii-kl merged commit 7108627 into main Jan 30, 2025
2 checks passed
@andrii-kl andrii-kl deleted the test/MTG-1029_determining-non-fungibile-tokens-by-token-state branch January 30, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armyhaylenko armyhaylenko armyhaylenko approved these changes

@kstepanovdev kstepanovdev kstepanovdev approved these changes

@n00m4d n00m4d Awaiting requested review from n00m4d

Assignees

@andrii-kl andrii-kl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-kl @kstepanovdev @armyhaylenko