Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add exclusive backoff for signature fetch #393

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

armyhaylenko
Copy link
Collaborator

No description provided.

@armyhaylenko armyhaylenko force-pushed the feat/MTG-1269-solana-rpc-backoff branch from 4c844f7 to f44dc61 Compare January 29, 2025 13:38
Copy link
Contributor

@kstepanovdev kstepanovdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super good, however, I have doubts regarding test methods in traits.

@armyhaylenko armyhaylenko force-pushed the feat/MTG-1269-solana-rpc-backoff branch 2 times, most recently from 821f5a0 to 5fb583d Compare January 29, 2025 14:23
@armyhaylenko armyhaylenko force-pushed the feat/MTG-1269-solana-rpc-backoff branch from 5fb583d to 0924a1f Compare January 29, 2025 15:22
@armyhaylenko armyhaylenko force-pushed the feat/MTG-1269-solana-rpc-backoff branch from 0924a1f to 68f14ba Compare January 29, 2025 15:29
@kstepanovdev kstepanovdev self-requested a review January 30, 2025 08:52
Copy link
Contributor

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! The only concern is the error propagation and checking on string

backfill_rpc/src/rpc.rs Show resolved Hide resolved
@armyhaylenko armyhaylenko merged commit 7d9d55b into main Jan 30, 2025
2 checks passed
@armyhaylenko armyhaylenko deleted the feat/MTG-1269-solana-rpc-backoff branch January 30, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants