feat(api): add Raydium price fetcher cache warmup for symbols #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nft_ingester/src/api/service.rs
Outdated
| @@ -111,6 +111,20 @@ pub async fn start_api( | |||
| } | |||
|
|
|||
| let addr = SocketAddr::from(([0, 0, 0, 0], port)); | |||
| let token_price_fetcher = Arc::new(RaydiumTokenPriceFetcher::new( | |||
| "https://api-v3.raydium.io".to_string(), | |||
There was a problem hiding this comment.
nit: I'd like to see it as a constant
armyhaylenko
force-pushed
the
feat/MTG-1257-add-raydium-cache-warmup
branch
from
c6c3a95 to
39c0457
Compare
| pub async fn warmup(&self) -> Result<(), IngesterError> { | ||
| #[derive(serde::Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| struct MintListItem { |
There was a problem hiding this comment.
Why do we want a declaration of structs inside a function? Does it do something useful?
There was a problem hiding this comment.
the struct is single-use and used to deserialize only one particular response for one particular function, to me it looks logical & so much better than .get("field") used previously
kstepanovdev
approved these changes
Jan 28, 2025
kstepanovdev
approved these changes
Jan 28, 2025
armyhaylenko
force-pushed
the
feat/MTG-1257-add-raydium-cache-warmup
branch
from
ed93329 to
d8beac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.