Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTG-1266] hotfix for migrations when the key encoding changes #386

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

StanChe
Copy link
Contributor

@StanChe StanChe commented Jan 26, 2025

The previous rocks migration changed the structure of Change Log Items, as well as the key encoding, putting the tree before the index, and thus keeping all tree-related change logs together, rather than dispersed. But the migration was putting the data using the old encoding of the keys, thus rendering invalid keys and no data after the migration. This did not affect the newly added data, or the backfilled data, but the migration itself.
This change allows preserving the data by properly migrating it.

Copy link
Collaborator

@armyhaylenko armyhaylenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

@StanChe StanChe changed the title hotfix for migrations when the key encoding changes [MTG-1266] hotfix for migrations when the key encoding changes Jan 27, 2025
@StanChe StanChe merged commit 1adc382 into main Jan 27, 2025
2 checks passed
@StanChe StanChe deleted the hotfix/migration-fix branch January 27, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants