Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTG-1223 Fix/Improve Clap implementation #375

Merged
merged 2 commits into from
Jan 20, 2025
Merged

MTG-1223 Fix/Improve Clap implementation #375

merged 2 commits into from
Jan 20, 2025

Conversation

andrii-kl
Copy link
Contributor

  • Allow disabling parameters (api, rocks_migration, backfiller) via Clap CLI when their default value is True
  • Improve parameter names for clarity
  • Add additional system logging
  • Replace old .env example

@andrii-kl
MTG-1223 Fix/Improve Clap implementation
0c5eaf2 
- Allow disabling parameters (api, rocks_migration, backfiller) via Clap CLI when their default value is True
- Improve parameter names for clarity
- Add additional system logging
- Replace old .env example
armyhaylenko
armyhaylenko approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@armyhaylenko armyhaylenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

nft_ingester/src/bin/ingester/main.rs Outdated Show resolved Hide resolved
@andrii-kl andrii-kl merged commit a10db36 into main Jan 20, 2025
2 checks passed
StanChe
StanChe reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep an eye for the logics changes before merging such changes

nft_ingester/src/config.rs Show resolved Hide resolved
nft_ingester/src/config.rs
)]
pub is_run_backfiller: bool,
pub run_backfiller: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

nft_ingester/src/config.rs
)]
pub is_run_bubblegum_backfiller: bool,
pub run_bubblegum_backfiller: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanChe StanChe StanChe left review comments

@armyhaylenko armyhaylenko armyhaylenko approved these changes

@n00m4d n00m4d Awaiting requested review from n00m4d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-kl @StanChe @armyhaylenko