-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTG-1044: add a separate secondary rocks backup service #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armyhaylenko
requested review from
StanChe,
kstepanovdev,
andrii-kl and
n00m4d
January 15, 2025 17:50
armyhaylenko
force-pushed
the
feat/MTG-1044-backup-service
branch
from
January 15, 2025 18:05
25ab6f8
to
35afdb4
Compare
andrii-kl
approved these changes
Jan 16, 2025
armyhaylenko
force-pushed
the
feat/MTG-1044-backup-service
branch
from
January 17, 2025 09:36
35afdb4
to
74d6a12
Compare
n00m4d
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's also add command to the Makefile
StanChe
reviewed
Jan 17, 2025
armyhaylenko
force-pushed
the
feat/MTG-1044-backup-service
branch
2 times, most recently
from
January 20, 2025 12:55
23a0aa9
to
8d1ef79
Compare
StanChe
reviewed
Jan 20, 2025
StanChe
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you!
armyhaylenko
force-pushed
the
feat/MTG-1044-backup-service
branch
from
January 23, 2025 14:47
3de8db1
to
221938b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.