Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor organisation contributor metadata: https://github.com/metano… #198

Merged
merged 1 commit into from
Nov 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ Encoding.default_internal = Encoding::UTF_8
source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}" }

gemspec
group :development, :test do
gem "rspec"
end

if File.exist? 'Gemfile.devel'
eval File.read('Gemfile.devel'), nil, 'Gemfile.devel' # rubocop:disable Security/Eval
if File.exist? "Gemfile.devel"
eval File.read("Gemfile.devel"), nil, "Gemfile.devel" # rubocop:disable Security/Eval
end

#gem "metanorma-cli"
gemspec
2 changes: 2 additions & 0 deletions Gemfile.devel
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
gem "metanorma-standoc", git: "https://github.com/metanorma/metanorma-standoc", branch: "features/logos"

6 changes: 6 additions & 0 deletions lib/metanorma/ietf/front.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ def metadata_author(node, xml)
personal_author(node, xml)
end

=begin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use block comments.

def metadata_publisher(node, xml)
publishers = node.attr("publisher") || "IETF"
csv_split(publishers)&.each do |p|
Expand All @@ -30,6 +31,11 @@ def metadata_copyright(node, xml)
end
end
end
=end

def default_publisher
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected.
Use 2 (not -4) spaces for indentation.

"IETF"
end

def org_abbrev
{ "Internet Engineering Task Force" => "IETF" }
Expand Down
Loading