Caption refactor Presentation XML: https://github.com/metanorma/isodo… #618

opoudjis · 2024-11-13T08:04:08Z

…c/issues/617

Metanorma PR checklist

Breaking changes (list related PRs)
Documentation update required (create task for this)
External dependency introduced (documentation update need)
Gem with native library introduced

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…ry delimiters, clause label processing: #617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

lib/isodoc/presentation_function/erefs.rb

@@ -5,7 +5,8 @@
    def citeas(xmldoc)
      xmldoc.xpath(ns("//eref | //origin | //quote//source")).each do |e|
        e["bibitemid"] && e["citeas"] or next
-        a = @xrefs.anchor(e["bibitemid"], :xref, false) and e["citeas"] = a
+        a = @xrefs.anchor(e["bibitemid"], :xref, false) and
+          e["citeas"] = a.gsub(%r{</?[^>]+>}, "")


To fix the problem, we need to ensure that all instances of the targeted pattern are removed from the input string. One effective way to achieve this is to apply the regular expression replacement repeatedly until no more replacements can be performed. This ensures that any remaining unsafe text is completely removed.

We will modify the citeas method to repeatedly apply the gsub replacement until the input string no longer changes. This approach guarantees that all HTML tags are removed, preventing any potential HTML element injection vulnerabilities.

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…n Presentation XML: #617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…n Presentation XML: #617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…etanorma/mn-native-pdf#770

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…ptions: metanorma/mn-native-pdf#770

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

Caption refactor Presentation XML: #617

084e820

opoudjis self-assigned this Nov 13, 2024

opoudjis marked this pull request as draft November 13, 2024 08:04

hound bot reviewed Nov 13, 2024

View reviewed changes

rationalise note, admon processing: #617

bab7aca

hound bot reviewed Nov 13, 2024

View reviewed changes

formula label delims, figure and sourcecode label processing, ToC ent…

941a9a2

…ry delimiters, clause label processing: #617

hound bot reviewed Nov 13, 2024

View reviewed changes

semantic annotation of complex xrefs: #617

b40ded7

hound bot reviewed Nov 13, 2024

View reviewed changes

rspec

8412745

hound bot reviewed Nov 13, 2024

View reviewed changes

rspec

6d377ec

hound bot reviewed Nov 13, 2024

View reviewed changes

semantically annotate xref rendering contents: #617

76b1aeb

hound bot reviewed Nov 14, 2024

View reviewed changes

better handling of non-paragraph content in term notes: #617

6ce108d

hound bot reviewed Nov 14, 2024

View reviewed changes

ensure dl has fmt-name: #617

670e9ae

hound bot reviewed Nov 14, 2024

View reviewed changes

ensure dl, ol, ul have fmt-name: #617

1064f72

hound bot reviewed Nov 14, 2024

View reviewed changes

rspec

17628e8

hound bot reviewed Nov 14, 2024

View reviewed changes

rspec

5cd1f3b

hound bot reviewed Nov 14, 2024

View reviewed changes

rspec

26f7ba2

hound bot reviewed Nov 14, 2024

View reviewed changes

rspec

d76b42d

hound bot reviewed Nov 14, 2024

View reviewed changes

hound bot reviewed Dec 2, 2024

View reviewed changes

https://github.com/metanorma/isodoc/issues/617

76f1ab0

hound bot reviewed Dec 2, 2024

View reviewed changes

https://github.com/metanorma/isodoc/issues/617

e1c2335

hound bot reviewed Dec 2, 2024

View reviewed changes

no semx markup in citeas: #617

0784b03

hound bot reviewed Dec 2, 2024

View reviewed changes

github-advanced-security bot found potential problems Dec 2, 2024

View reviewed changes

opoudjis added 2 commits December 3, 2024 11:22

rspec

7328475

https://github.com/metanorma/isodoc/issues/617

52bbf76

hound bot reviewed Dec 3, 2024

View reviewed changes

bugfix: reversing order of multiple preface elements with same name i…

8a9bcc5

…n Presentation XML: #617

hound bot reviewed Dec 3, 2024

View reviewed changes

bugfix: reversing order of multiple preface elements with same name i…

2714726

…n Presentation XML: #617

hound bot reviewed Dec 3, 2024

View reviewed changes

rspec

a28908b

hound bot reviewed Dec 4, 2024

View reviewed changes

remove duplicate IDs between Semantic and Presentation XML captions: m…

6a37097

…etanorma/mn-native-pdf#770

hound bot reviewed Dec 5, 2024

View reviewed changes

remove duplicate index terms between Semantic and Presentation XML ca…

ff926c7

…ptions: metanorma/mn-native-pdf#770

hound bot reviewed Dec 5, 2024

View reviewed changes

Kanji for 'and' in Japanese: #624

cc0a013

hound bot reviewed Dec 7, 2024

View reviewed changes

rspec

07297c1

opoudjis marked this pull request as ready for review December 8, 2024 11:17

hound bot reviewed Dec 8, 2024

View reviewed changes

Merge branch 'main' into feature/presxml-autonum

e7db0c6

opoudjis merged commit 417c222 into main Dec 8, 2024
2 of 4 checks passed

hound bot reviewed Dec 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Caption refactor Presentation XML: https://github.com/metanorma/isodo… #618

Caption refactor Presentation XML: https://github.com/metanorma/isodo… #618

opoudjis commented Nov 13, 2024

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

@@ -8,4 +8,16 @@
                     a = @xrefs.anchor(e["bibitemid"], :xref, false) and
-                      e["citeas"] = a.gsub(%r{</?[^>]+>}, "")
+                      e["citeas"] = remove_html_tags(a)
                   end
+                  end
+                end
+                private
+                def remove_html_tags(input)
+                  previous = nil
+                  while input != previous
+                    previous = input
+                    input = input.gsub(%r{</?[^>]+>}, "")
+                  end
+                  input
                 end

Caption refactor Presentation XML: https://github.com/metanorma/isodo… #618

Caption refactor Presentation XML: https://github.com/metanorma/isodo… #618

Conversation

opoudjis commented Nov 13, 2024

Metanorma PR checklist

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment