-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Presentation XML for terms, PDF #632
Comments
metanorma-iso done |
@opoudjis 1. to be on the same page,
do you mean the element
do you mean the element
I didn't find the processing for this element in the XSLTs. Could you provide how to encode the 'related' term and the rendering rules?
The
<domain id="_8817ef17-ec60-4d1a-b288-8ab03f7efb2d">rice</domain> The previous generated Presentation XML: <domain hidden="true">rice</domain> |
Yes, and yes.
Huh, so I had resolved it before to just paragraphs I guess. Treat "related" by default like "admitted". It is cross-references to other terms, and I was resolving it as just a paragraph: Semantic XML:
Previous Presentation XML:
As you can see, the Related content was rendered as just paragraphs. Now those paragraphs are going to be contained inside a single fmt-related element:
Deliberate. The "hidden" attribute is not to be used, because the |
Thank you for catching that. That is indeed an omission. Will try to resolve now. |
Change coming up, I will be leaving fmt-termsource inside of fmt-preferred where the choice of term designation is attributed to a source. Before, I was moving termsource after preferred. So you will find fmt-termsource inside of any of preferred admitted deprecates definition as well as term itself—although I don't think that's going to have much of an impact on you, you just output its contents where you find them, and there will be no implicit paragraphs anywhere for you to insert, I am taking care of those. |
Yup, I realise what happened: concepts in terms are a special case in ISO: only the first instance is hyperlinked, but that's the first rendered instance. Which means I need to leave |
Fixed:
|
Metanorma-IEEE ready |
ISO XSLT updated in https://github.com/metanorma/mn-native-pdf/tree/update_pres_xml_part5. |
@opoudjis in the <term id="term-acceleration-insensitive-drift-rate">
...
<fmt-definition>
<p>
<semx element="preferred" source="_7180a9d8-eabd-46e6-ae62-b7e2c411effa">
<strong>acceleration-insensitive drift rate</strong>
</semx>: <semx element="definition" source="_87074daf-1bfa-424b-b784-cd68750c8733">The component of…</semx>
<em>See also:</em>
<semx element="related" source="_59f0e153-1ee6-4828-aa43-dee2d69610f7">
...
<fmt-preferred>
<semx element="preferred" source="_f9d4baba-d4ac-4a49-8239-689258d11efc">
<strong>drift rate</strong>
</semx>
</fmt-preferred>
<xref target="term-drift-rate">drift rate</xref>
</semx>; <semx element="related" source="_f4b74950-583e-4578-a973-222b15cd39fb">
...
<fmt-preferred>
<semx element="preferred" source="_66c162c9-7c10-4c59-83ad-97b906ce9627">
<strong>systematic drift rate</strong>
</semx>
</fmt-preferred>
<xref target="term-systematic-drift-rate">systematic drift rate</xref>
</semx>. </p>
</fmt-definition> |
@opoudjis confirmed, thank you. |
metanorma-itu ready. Will come back to xref issue, I'm out the door... |
common.xsl updated for ITU. |
metanorma-nist ready |
Those appear to be specific to related. They are redundant, and I'll get rid of them. |
Yes, in IEEE, the xref of where the related term is is ignored. |
metanorma-ogc ready |
metanorma-csa, metanorma-cc, metanorma-iho ready |
The same issue with OGC documents. |
I'll continue after the missing |
metanorma-bsi ready |
NIST, and OGC: I disabled bolding, but that makes no sense, I was misled by bad test cases. Restored. |
metanorma-plateau, metanorma-bipm ready |
Confirmed. @opoudjis thanks! |
No need NIST and OGC XSLT update. common.xsl was updated earlier. |
No need CSA. CSD and IHO XSLT update. |
Ribose XSLT updated. |
No need update the JIS XSLT. |
@opoudjis do you have the adoc document sample for this case? |
No need update for the BSI XSLT. |
@opoudjis I've found it: https://github.com/glossarist/iev-document/ |
Only English terms present in the adoc unfortunately. @opoudjis Nevertheless, I need the working adoc example for IEV multilingual terms. |
No need to update Plateau XSLT. |
At the risk of being glib, if we didn't have a multilingual IEV sample document before, then we may not have had anything to test again before this refactor, so we don't know that it wasn't buggy before anyway. I am not aware of any IEV multilingual test documents: the ticket request to implement this was glossarist/iev-document#18 , but all I got from @ronaldtse for that was a screenshot, not a document. In my opinion this feature should not hold up the Presentation XML terms refactor for release next week (which appears otherwise to have gone smoothly); if there are issues, we will find them if we ever have an IEV multilingual document to deal with. (Big if.) If @ronaldtse thinks differently, he will need to source a multilingual IEV document. There is of course XML in the metanorma-iec test files: https://github.com/metanorma/metanorma-iec/blob/feature/presentation-terms/spec/isodoc/iev_spec.rb It's the last test case:
|
@opoudjis thank you! ITU XSLT updated. All XSLT updated in metanorma/mn-native-pdf#797. |
That exactly is an IEV multilingual document. Is the complaint that the screenshotted document is not properly encoded? |
Done. metanorma/mn-native-pdf#797 is ready to merge. |
No, it's that we don't have softcopy for @Intelligent2013 to test against. |
Follow-on from #630
I am incrementally doing the refactoring of terms in Presentation XML. As with the other refactoring, this is going to be one flavour at a time, and I've just done the base flavour implementation. You can see it in #631
The basic point of this is that
semx
is used to link Presentation XML back to the Semantic XML originalspreferred alternative deprecated related definition termsource
in favour offmt-preferred fmt-alternative fmt-deprecated fmt-related fmt-definition fmt-termsource
preferred alternative deprecated related
, there is only a single instance offmt-preferred fmt-alternative fmt-deprecated fmt-related
. The latter now contain paragraphs, and multiple paragraphs withinfmt-preferred
are used instead of multiplepreferred
terms for the purposes of rendering.Downstream flavours are going to arrange these terms quite differently, e.g. inserting the preferred terms inside of the definition at the start of the paragraph for ITU.
You can see samples of what the new Presentation XML looks like in https://github.com/metanorma/isodoc/pull/631/files#diff-a8f22a60cfd3fb8aedb49cf416629cbee802bbf4cd0225b7a221419a3ac68b88 , in spec/isodoc/terms_spec.rb
The text was updated successfully, but these errors were encountered: