Only send back the issue ids on eval.

metal-stack · Oct 10, 2023 · e1bf2de · e1bf2de
1 parent b7feec1
commit e1bf2de
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/cmd/metal-api/internal/service/machine-service.go b/cmd/metal-api/internal/service/machine-service.go
@@ -617,13 +617,7 @@ func (r *machineResource) issues(request *restful.Request, response *restful.Res
 		for _, issue := range machineWithIssues.Issues {
 			issue := issue
 
-			entry.Issues = append(entry.Issues, v1.MachineIssue{
-				ID:          string(issue.Type),
-				Severity:    string(issue.Severity),
-				Description: issue.Description,
-				RefURL:      issue.RefURL,
-				Details:     issue.Details,
-			})
+			entry.Issues = append(entry.Issues, string(issue.Type))
 		}
 
 		issueResponse = append(issueResponse, entry)

diff --git a/cmd/metal-api/internal/service/v1/machine.go b/cmd/metal-api/internal/service/v1/machine.go
@@ -287,8 +287,8 @@ type MachineVPN struct {
 }
 
 type MachineIssueResponse struct {
-	MachineID string         `json:"machineid" description:"the machine id that has the given issues"`
-	Issues    []MachineIssue `json:"issues" description:"the list of issues of this machine"`
+	MachineID string   `json:"machineid" description:"the machine id that has the given issues"`
+	Issues    []string `json:"issues" description:"the list of issues (only issue ids) of this machine"`
 }
 
 type MachineIssue struct {

diff --git a/spec/metal-api.json b/spec/metal-api.json
@@ -2770,9 +2770,9 @@
     "v1.MachineIssueResponse": {
       "properties": {
         "issues": {
-          "description": "the list of issues of this machine",
+          "description": "the list of issues (only issue ids) of this machine",
           "items": {
-            "$ref": "#/definitions/v1.MachineIssue"
+            "type": "string"
           },
           "type": "array"
         },