Issue types can be private as well.

metal-stack · Oct 10, 2023 · b15b803 · b15b803
1 parent 5dce260
commit b15b803
Show file tree

Hide file tree

Showing 17 changed files with 81 additions and 81 deletions.
diff --git a/cmd/metal-api/internal/issues/asn-uniqueness.go b/cmd/metal-api/internal/issues/asn-uniqueness.go
@@ -13,12 +13,12 @@ const (
 )
 
 type (
-	IssueASNUniqueness struct {
+	issueASNUniqueness struct {
 		details string
 	}
 )
 
-func (i *IssueASNUniqueness) Spec() *spec {
+func (i *issueASNUniqueness) Spec() *spec {
 	return &spec{
 		Type:        TypeASNUniqueness,
 		Severity:    SeverityMinor,
@@ -27,7 +27,7 @@ func (i *IssueASNUniqueness) Spec() *spec {
 	}
 }
 
-func (i *IssueASNUniqueness) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueASNUniqueness) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	var (
 		machineASNs  = map[uint32]metal.Machines{}
 		overlaps     []string
@@ -117,6 +117,6 @@ func (i *IssueASNUniqueness) Evaluate(m metal.Machine, ec metal.ProvisioningEven
 	return true
 }
 
-func (i *IssueASNUniqueness) Details() string {
+func (i *issueASNUniqueness) Details() string {
 	return i.details
 }
diff --git a/cmd/metal-api/internal/issues/bmc-info-outdated.go b/cmd/metal-api/internal/issues/bmc-info-outdated.go
@@ -12,16 +12,16 @@ const (
 )
 
 type (
-	IssueBMCInfoOutdated struct {
+	issueBMCInfoOutdated struct {
 		details string
 	}
 )
 
-func (i *IssueBMCInfoOutdated) Details() string {
+func (i *issueBMCInfoOutdated) Details() string {
 	return i.details
 }
 
-func (i *IssueBMCInfoOutdated) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueBMCInfoOutdated) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	if m.IPMI.LastUpdated.IsZero() {
 		i.details = "machine ipmi has never been set"
 		return true
@@ -37,7 +37,7 @@ func (i *IssueBMCInfoOutdated) Evaluate(m metal.Machine, ec metal.ProvisioningEv
 	return false
 }
 
-func (*IssueBMCInfoOutdated) Spec() *spec {
+func (*issueBMCInfoOutdated) Spec() *spec {
 	return &spec{
 		Type:        TypeBMCInfoOutdated,
 		Severity:    SeverityMajor,

diff --git a/cmd/metal-api/internal/issues/bmc-without-ip.go b/cmd/metal-api/internal/issues/bmc-without-ip.go
@@ -7,10 +7,10 @@ const (
 )
 
 type (
-	IssueBMCWithoutIP struct{}
+	issueBMCWithoutIP struct{}
 )
 
-func (i *IssueBMCWithoutIP) Spec() *spec {
+func (i *issueBMCWithoutIP) Spec() *spec {
 	return &spec{
 		Type:        TypeBMCWithoutIP,
 		Severity:    SeverityMajor,
@@ -19,10 +19,10 @@ func (i *IssueBMCWithoutIP) Spec() *spec {
 	}
 }
 
-func (i *IssueBMCWithoutIP) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueBMCWithoutIP) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	return m.IPMI.Address == ""
 }
 
-func (i *IssueBMCWithoutIP) Details() string {
+func (i *issueBMCWithoutIP) Details() string {
 	return ""
 }
diff --git a/cmd/metal-api/internal/issues/bmc-without-mac.go b/cmd/metal-api/internal/issues/bmc-without-mac.go
@@ -7,10 +7,10 @@ const (
 )
 
 type (
-	IssueBMCWithoutMAC struct{}
+	issueBMCWithoutMAC struct{}
 )
 
-func (i *IssueBMCWithoutMAC) Spec() *spec {
+func (i *issueBMCWithoutMAC) Spec() *spec {
 	return &spec{
 		Type:        TypeBMCWithoutMAC,
 		Severity:    SeverityMajor,
@@ -19,10 +19,10 @@ func (i *IssueBMCWithoutMAC) Spec() *spec {
 	}
 }
 
-func (i *IssueBMCWithoutMAC) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueBMCWithoutMAC) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	return m.IPMI.MacAddress == ""
 }
 
-func (i *IssueBMCWithoutMAC) Details() string {
+func (i *issueBMCWithoutMAC) Details() string {
 	return ""
 }
diff --git a/cmd/metal-api/internal/issues/crash-loop.go b/cmd/metal-api/internal/issues/crash-loop.go
@@ -10,10 +10,10 @@ const (
 )
 
 type (
-	IssueCrashLoop struct{}
+	issueCrashLoop struct{}
 )
 
-func (i *IssueCrashLoop) Spec() *spec {
+func (i *issueCrashLoop) Spec() *spec {
 	return &spec{
 		Type:        TypeCrashLoop,
 		Severity:    SeverityMajor,
@@ -22,7 +22,7 @@ func (i *IssueCrashLoop) Spec() *spec {
 	}
 }
 
-func (i *IssueCrashLoop) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueCrashLoop) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	if ec.CrashLoop {
 		if pointer.FirstOrZero(ec.Events).Event == metal.ProvisioningEventWaiting {
 			// Machine which are waiting are not considered to have issues
@@ -33,6 +33,6 @@ func (i *IssueCrashLoop) Evaluate(m metal.Machine, ec metal.ProvisioningEventCon
 	return false
 }
 
-func (i *IssueCrashLoop) Details() string {
+func (i *issueCrashLoop) Details() string {
 	return ""
 }
diff --git a/cmd/metal-api/internal/issues/failed-machine-reclaim.go b/cmd/metal-api/internal/issues/failed-machine-reclaim.go
@@ -10,10 +10,10 @@ const (
 )
 
 type (
-	IssueFailedMachineReclaim struct{}
+	issueFailedMachineReclaim struct{}
 )
 
-func (i *IssueFailedMachineReclaim) Spec() *spec {
+func (i *issueFailedMachineReclaim) Spec() *spec {
 	return &spec{
 		Type:        TypeFailedMachineReclaim,
 		Severity:    SeverityCritical,
@@ -22,7 +22,7 @@ func (i *IssueFailedMachineReclaim) Spec() *spec {
 	}
 }
 
-func (i *IssueFailedMachineReclaim) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueFailedMachineReclaim) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	if ec.FailedMachineReclaim {
 		return true
 	}
@@ -36,6 +36,6 @@ func (i *IssueFailedMachineReclaim) Evaluate(m metal.Machine, ec metal.Provision
 	return false
 }
 
-func (i *IssueFailedMachineReclaim) Details() string {
+func (i *issueFailedMachineReclaim) Details() string {
 	return ""
 }
diff --git a/cmd/metal-api/internal/issues/issues.go b/cmd/metal-api/internal/issues/issues.go
@@ -98,7 +98,7 @@ func FindIssues(c *Config) (MachineIssuesMap, error) {
 
 		ec, ok := ecs[m.ID]
 		if !ok {
-			res.add(m, toIssue(&IssueNoEventContainer{}))
+			res.add(m, toIssue(&issueNoEventContainer{}))
 			continue
 		}
 

diff --git a/cmd/metal-api/internal/issues/issues_test.go b/cmd/metal-api/internal/issues/issues_test.go
@@ -79,7 +79,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[0],
 						Issues: Issues{
-							toIssue(&IssueNoPartition{}),
+							toIssue(&issueNoPartition{}),
 						},
 					},
 				}
@@ -108,7 +108,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[0],
 						Issues: Issues{
-							toIssue(&IssueLivelinessDead{}),
+							toIssue(&issueLivelinessDead{}),
 						},
 					},
 				}
@@ -137,7 +137,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[0],
 						Issues: Issues{
-							toIssue(&IssueLivelinessUnknown{}),
+							toIssue(&issueLivelinessUnknown{}),
 						},
 					},
 				}
@@ -166,7 +166,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[0],
 						Issues: Issues{
-							toIssue(&IssueLivelinessNotAvailable{}),
+							toIssue(&issueLivelinessNotAvailable{}),
 						},
 					},
 				}
@@ -206,13 +206,13 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[1],
 						Issues: Issues{
-							toIssue(&IssueFailedMachineReclaim{}),
+							toIssue(&issueFailedMachineReclaim{}),
 						},
 					},
 					{
 						Machine: &machines[2],
 						Issues: Issues{
-							toIssue(&IssueFailedMachineReclaim{}),
+							toIssue(&issueFailedMachineReclaim{}),
 						},
 					},
 				}
@@ -241,7 +241,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[1],
 						Issues: Issues{
-							toIssue(&IssueCrashLoop{}),
+							toIssue(&issueCrashLoop{}),
 						},
 					},
 				}
@@ -306,7 +306,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[1],
 						Issues: Issues{
-							toIssue(&IssueBMCWithoutMAC{}),
+							toIssue(&issueBMCWithoutMAC{}),
 						},
 					},
 				}
@@ -338,7 +338,7 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[1],
 						Issues: Issues{
-							toIssue(&IssueBMCWithoutIP{}),
+							toIssue(&issueBMCWithoutIP{}),
 						},
 					},
 				}
@@ -430,15 +430,15 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[0],
 						Issues: Issues{
-							toIssue(&IssueASNUniqueness{
+							toIssue(&issueASNUniqueness{
 								details: fmt.Sprintf("- ASN (100) not unique, shared with [%[1]s]\n- ASN (200) not unique, shared with [%[1]s]", machines[1].ID),
 							}),
 						},
 					},
 					{
 						Machine: &machines[1],
 						Issues: Issues{
-							toIssue(&IssueASNUniqueness{
+							toIssue(&issueASNUniqueness{
 								details: fmt.Sprintf("- ASN (100) not unique, shared with [%[1]s]\n- ASN (200) not unique, shared with [%[1]s]", machines[0].ID),
 							}),
 						},
@@ -474,15 +474,15 @@ func TestFindIssues(t *testing.T) {
 					{
 						Machine: &machines[0],
 						Issues: Issues{
-							toIssue(&IssueNonDistinctBMCIP{
+							toIssue(&issueNonDistinctBMCIP{
 								details: fmt.Sprintf("BMC IP (127.0.0.1) not unique, shared with [%[1]s]", machines[1].ID),
 							}),
 						},
 					},
 					{
 						Machine: &machines[1],
 						Issues: Issues{
-							toIssue(&IssueNonDistinctBMCIP{
+							toIssue(&issueNonDistinctBMCIP{
 								details: fmt.Sprintf("BMC IP (127.0.0.1) not unique, shared with [%[1]s]", machines[0].ID),
 							}),
 						},
@@ -509,7 +509,7 @@ func TestFindIssues(t *testing.T) {
 				want = tt.want(ms)
 			}
 
-			if diff := cmp.Diff(want, got.ToList(), cmp.AllowUnexported(IssueLastEventError{}, IssueASNUniqueness{}, IssueNonDistinctBMCIP{})); diff != "" {
+			if diff := cmp.Diff(want, got.ToList(), cmp.AllowUnexported(issueLastEventError{}, issueASNUniqueness{}, issueNonDistinctBMCIP{})); diff != "" {
 				t.Errorf("diff (+got -want):\n %s", diff)
 			}
 		})

diff --git a/cmd/metal-api/internal/issues/last-event-error.go b/cmd/metal-api/internal/issues/last-event-error.go
@@ -12,7 +12,7 @@ const (
 )
 
 type (
-	IssueLastEventError struct {
+	issueLastEventError struct {
 		details string
 	}
 )
@@ -21,7 +21,7 @@ func DefaultLastErrorThreshold() time.Duration {
 	return 7 * 24 * time.Hour
 }
 
-func (i *IssueLastEventError) Spec() *spec {
+func (i *issueLastEventError) Spec() *spec {
 	return &spec{
 		Type:        TypeLastEventError,
 		Severity:    SeverityMinor,
@@ -30,7 +30,7 @@ func (i *IssueLastEventError) Spec() *spec {
 	}
 }
 
-func (i *IssueLastEventError) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueLastEventError) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	if c.LastErrorThreshold == 0 {
 		return false
 	}
@@ -46,6 +46,6 @@ func (i *IssueLastEventError) Evaluate(m metal.Machine, ec metal.ProvisioningEve
 	return false
 }
 
-func (i *IssueLastEventError) Details() string {
+func (i *issueLastEventError) Details() string {
 	return i.details
 }
diff --git a/cmd/metal-api/internal/issues/liveliness-dead.go b/cmd/metal-api/internal/issues/liveliness-dead.go
@@ -7,10 +7,10 @@ const (
 )
 
 type (
-	IssueLivelinessDead struct{}
+	issueLivelinessDead struct{}
 )
 
-func (i *IssueLivelinessDead) Spec() *spec {
+func (i *issueLivelinessDead) Spec() *spec {
 	return &spec{
 		Type:        TypeLivelinessDead,
 		Severity:    SeverityMajor,
@@ -19,10 +19,10 @@ func (i *IssueLivelinessDead) Spec() *spec {
 	}
 }
 
-func (i *IssueLivelinessDead) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueLivelinessDead) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	return ec.Liveliness == metal.MachineLivelinessDead
 }
 
-func (i *IssueLivelinessDead) Details() string {
+func (i *issueLivelinessDead) Details() string {
 	return ""
 }
diff --git a/cmd/metal-api/internal/issues/liveliness-not-available.go b/cmd/metal-api/internal/issues/liveliness-not-available.go
@@ -7,18 +7,18 @@ const (
 )
 
 type (
-	IssueLivelinessNotAvailable struct{}
+	issueLivelinessNotAvailable struct{}
 )
 
-func (i *IssueLivelinessNotAvailable) Spec() *spec {
+func (i *issueLivelinessNotAvailable) Spec() *spec {
 	return &spec{
 		Type:        TypeLivelinessNotAvailable,
 		Severity:    SeverityMinor,
 		Description: "the machine liveliness is not available",
 	}
 }
 
-func (i *IssueLivelinessNotAvailable) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
+func (i *issueLivelinessNotAvailable) Evaluate(m metal.Machine, ec metal.ProvisioningEventContainer, c *Config) bool {
 	allowed := map[metal.MachineLiveliness]bool{
 		metal.MachineLivelinessAlive:   true,
 		metal.MachineLivelinessDead:    true,
@@ -28,6 +28,6 @@ func (i *IssueLivelinessNotAvailable) Evaluate(m metal.Machine, ec metal.Provisi
 	return !allowed[ec.Liveliness]
 }
 
-func (i *IssueLivelinessNotAvailable) Details() string {
+func (i *issueLivelinessNotAvailable) Details() string {
 	return ""
 }