Firewall ingress rule destinations are optional, too. (#504)

metal-stack · Feb 15, 2024 · 9458c9d · 9458c9d
1 parent c9e4944
commit 9458c9d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cmd/metal-api/internal/service/v1/firewall.go b/cmd/metal-api/internal/service/v1/firewall.go
@@ -19,7 +19,7 @@ type FirewallEgressRule struct {
 type FirewallIngressRule struct {
 	Protocol string   `json:"protocol,omitempty" description:"the protocol for the rule, defaults to tcp" enum:"tcp|udp" optional:"true"`
 	Ports    []int    `json:"ports" description:"the ports affected by this rule"`
-	To       []string `json:"to" description:"the cidrs affected by this rule"`
+	To       []string `json:"to,omitempty" description:"the cidrs affected by this rule" optional:"true"`
 	From     []string `json:"from" description:"the cidrs affected by this rule"`
 	Comment  string   `json:"comment,omitempty" description:"an optional comment describing what this rule is used for" optional:"true"`
 }

diff --git a/spec/metal-api.json b/spec/metal-api.json
@@ -1365,8 +1365,7 @@
       },
       "required": [
         "from",
-        "ports",
-        "to"
+        "ports"
       ]
     },
     "v1.FirewallResponse": {
-Original file line number
+Diff line change
@@ Expand Up / @@ -1365,8 +1365,7 @@ @@
           },
           "required": [
             "from",
-            "ports",
-            "to"
+            "ports"
           ]
         },
         "v1.FirewallResponse": {
@@ Expand Down @@