WIP to use the default option as in catmandu #333 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasNx
force-pushed
the
333-defaultOptionWIP
branch
from
6b01722
to
18b78f0
Compare
blackwinter
requested changes
Jul 1, 2024
| @@ -530,8 +531,11 @@ public void apply(final Metafix metafix, final Record record, final List<String> | |||
| if (c != null) { | |||
| c.accept(oldValue); | |||
| } | |||
|
|
|||
| elsif (defaultOption != null){ | |||
There was a problem hiding this comment.
This branch will not be reached when print_unknown="true".
|
|
||
| elsif (defaultOption != null){ | ||
| return defaultOption; | ||
| } | ||
| return defaultValue != null ? defaultValue : delete ? null : oldValue; |
There was a problem hiding this comment.
Suggested change
| return defaultValue != null ? defaultValue : delete ? null : oldValue; | |
| return defaultOption != null ? defaultOption : defaultValue != null ? defaultValue : delete ? null : oldValue; |
As previously suggested, this would be even better though (at the top of the method):
final String defaultValue = options.getOrDefault(Maps.DEFAULT_MAP_KEY, map.get(Maps.DEFAULT_MAP_KEY));It would allow you to specify/override the default value per lookup call in addition to per map. The next step would then be to decide whether we want to keep supporting the Metamorph syntax (__default) or switch to the Catmandu syntax (default). Or even support both (which seems a little messy, though).
| return defaultValue != null ? defaultValue : delete ? null : oldValue; | ||
|
|
There was a problem hiding this comment.
Please don't add/remove empty lines in existing code ;)
TobiasNx
force-pushed
the
333-defaultOptionWIP
branch
from
1e4938e
to
a505fc5
Compare
|
@blackwinter could you help me how I would continue here? I would suggest to drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.