Preserve imported annotation on approval & Add SeriesImport model #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellnerd
changed the title
kellnerd
force-pushed
the
import-annotation
branch
from
b978ae8
to
1d129f9
Compare
Approving an Edition Group import failed previously: > error: select "data_id" from "bookbrainz"."editiongroup_import_header" where "import_id" = $1 - relation "bookbrainz.editiongroup_import_header" does not exist
6 tasks
kellnerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #320.
Now that I could actually test creating imports with annotations after the schema change, I found two issues with the "Approve" action which have to be fixed in the ORM.
First we have to avoid losing the annotation and then we can also set the annotation's latest revision now that the entity gets its first revision.
In order to get annotations (and the entity pages/routes in general) working for all types of imported entities, a couple of additional changes were necessary, the biggest being the addition of the missing SeriesImport model.