Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify entity validators #316

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Unify entity validators #316

merged 12 commits into from
Jun 26, 2024

Commits on Jun 17, 2024

  1. chore: Copy entity validators from bookbrainz-site 

    src/client/entity-editor/validators/
    @kellnerd
    kellnerd committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b99a66d View commit details
    Browse the repository at this point in the history

  2. fix: Repair validator imports which broke during copying 

    - Copy a few utilities from bookbrainz-site/src/client/helpers/utils.tsx
- Replace `IdentifierType` duck types with existing complete definition
    @kellnerd
    kellnerd committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    715b443 View commit details
    Browse the repository at this point in the history

  3. chore(deps): Install "validator" which is used by the copied validators

    @kellnerd
    kellnerd committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    294734a View commit details
    Browse the repository at this point in the history

  4. chore: Copy validator tests from bookbrainz-site and update import paths 

    test/src/client/entity-editor/validators/
    @kellnerd
    kellnerd committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7b02934 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. refactor(test): Expect all validators to throw or not 

    This way we can return the reason for the failed validation instead of
just a boolean.
    @kellnerd
    kellnerd committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ac88c0b View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. refactor: Make entity validators throw instead of returning a boolean

    @kellnerd
    kellnerd committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b53fe61 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. chore(validators): Update copyright headers

    @kellnerd
    kellnerd committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7849e1b View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. chore(validators): Copy section type definitions from bookbrainz-utils

    @kellnerd
    kellnerd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cd5ab85 View commit details
    Browse the repository at this point in the history

  2. feat(validators): Define missing series section type

    @kellnerd
    kellnerd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    436d008 View commit details
    Browse the repository at this point in the history

  3. feat: Validate optional boolean flag alias.default of imports

    @kellnerd
    kellnerd committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a912ab9 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. feat(validators): Define missing author credit section type

    @kellnerd
    kellnerd committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    85cf422 View commit details
    Browse the repository at this point in the history

  2. chore: Mute eslint complexity warning for dateValidator

    @kellnerd
    kellnerd committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f3ec5ea View commit details
    Browse the repository at this point in the history