-
Notifications
You must be signed in to change notification settings - Fork 45
Move aten input loader to the new loader style #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+18
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea26cd3
to
0fe2c1c
Compare
xuzhao9
added a commit
that referenced
this pull request
Oct 2, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
xuzhao9
added a commit
that referenced
this pull request
Oct 2, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
0fe2c1c
to
88fe95a
Compare
xuzhao9
added a commit
that referenced
this pull request
Oct 2, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
88fe95a
to
6fffb13
Compare
xuzhao9
added a commit
that referenced
this pull request
Oct 2, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
6fffb13
to
cde6a7d
Compare
xuzhao9
added a commit
that referenced
this pull request
Oct 2, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
cde6a7d
to
ce54fa4
Compare
xuzhao9
added a commit
that referenced
this pull request
Oct 3, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
ce54fa4
to
14f6dd2
Compare
xuzhao9
added a commit
that referenced
this pull request
Oct 4, 2025
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
14f6dd2
to
081bdba
Compare
@FindHao , can I get a review? |
Summary: Pull Request resolved: #507 We are refactoring the input loader component. Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator. The same interface holds for operator loaders like aten. Reviewed By: FindHao Differential Revision: D83754693
081bdba
to
7b10e65
Compare
FindHao
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are refactoring the input loader component.
Now, each operator must implement its input loader script in the
input-loader.py
under its directory. This file must provide a function,get_input_loader(tritonbench_op: Any, op: str, input: str)
, which will be plugged in as the new input generator.The same interface holds for operator loaders like aten.
Reviewed By: FindHao
Differential Revision: D83754693