Skip to content

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Oct 2, 2025

Summary:
We are refactoring the input loader component.

Now, each operator must implement its input loader script in the input-loader.py under its directory. This file must provide a function, get_input_loader(tritonbench_op: Any, op: str, input: str), which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83754693.

xuzhao9 added a commit that referenced this pull request Oct 2, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
@xuzhao9 xuzhao9 requested a review from FindHao October 2, 2025 18:58
xuzhao9 added a commit that referenced this pull request Oct 2, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
xuzhao9 added a commit that referenced this pull request Oct 2, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
xuzhao9 added a commit that referenced this pull request Oct 2, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 2, 2025 19:14 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 2, 2025 19:14 — with GitHub Actions Inactive
xuzhao9 added a commit that referenced this pull request Oct 2, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 2, 2025 19:49 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 2, 2025 19:49 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 2, 2025 19:49 — with GitHub Actions Inactive
xuzhao9 added a commit that referenced this pull request Oct 3, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 3, 2025 13:08 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 3, 2025 13:08 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 3, 2025 13:08 — with GitHub Actions Inactive
xuzhao9 added a commit that referenced this pull request Oct 4, 2025
Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 4, 2025 01:34 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 4, 2025 01:34 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 4, 2025 01:34 — with GitHub Actions Inactive
@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Oct 6, 2025

@FindHao , can I get a review?

Summary:
Pull Request resolved: #507

We are refactoring the input loader component.

Now, each operator must implement its input loader script in the `input-loader.py` under its directory. This file must provide a function, `get_input_loader(tritonbench_op: Any, op: str, input: str)`, which will be plugged in as the new input generator.

The same interface holds for operator loaders like aten.

Reviewed By: FindHao

Differential Revision: D83754693
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 6, 2025 20:18 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 6, 2025 20:18 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload October 6, 2025 20:18 — with GitHub Actions Inactive
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meta-codesync meta-codesync bot merged commit fdb7ac7 into main Oct 7, 2025
8 of 10 checks passed
@xuzhao9 xuzhao9 deleted the export-D83754693 branch October 7, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants