-
Notifications
You must be signed in to change notification settings - Fork 45
Refactor fp8_gemm benchmark to simplify addition of new scaling modes #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jananisriram
wants to merge
1
commit into
main
Choose a base branch
from
export-D83617233
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jananisriram has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83617233. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
41d6363
to
2e928c2
Compare
xuzhao9
approved these changes
Oct 1, 2025
jananisriram
added a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
2e928c2
to
f7af150
Compare
jananisriram
added a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
f7af150
to
869e85a
Compare
jananisriram
added a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
869e85a
to
9a31687
Compare
jananisriram
added a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
b722a3d
to
5ed12ce
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
5ed12ce
to
371fd82
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
371fd82
to
717aa8a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Differential Revision: D83617233
jananisriram
added a commit
that referenced
this pull request
Oct 2, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Reviewed By: NikhilAPatel Differential Revision: D83617233
717aa8a
to
54f8fb8
Compare
jananisriram
added a commit
that referenced
this pull request
Oct 2, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Reviewed By: NikhilAPatel Differential Revision: D83617233
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Reviewed By: NikhilAPatel Differential Revision: D83617233
54f8fb8
to
9e02064
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Reviewed By: NikhilAPatel Differential Revision: D83617233
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…#500) Summary: Refactor the `fp8_gemm` benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend the `fp8_gemm` benchmark to new scaling modes without adding new benchmarking arguments. Reviewed By: NikhilAPatel Differential Revision: D83617233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactor the
fp8_gemm
benchmark in TritonBench to accept scaling modes as an argument. This diff enables us to extend thefp8_gemm
benchmark to new scaling modes without adding new benchmarking arguments.Differential Revision: D83617233