Add validations for rec metrics config creation to avoid out of bounds indices #3421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
nipung90
force-pushed
the
export-D83764096
branch
from
71fbd46 to
f8f50cf
Compare
nipung90
added a commit
to nipung90/torchrec
that referenced
this pull request
Oct 2, 2025
…s indices (meta-pytorch#3421) Summary: This validation would avoid issues like: https://fb.workplace.com/groups/755371733754414/posts/794025843514383/ Differential Revision: D83764096
nipung90
force-pushed
the
export-D83764096
branch
from
f8f50cf to
d3956c4
Compare
nipung90
added a commit
to nipung90/torchrec
that referenced
this pull request
Oct 6, 2025
…s indices (meta-pytorch#3421) Summary: This validation would avoid issues like: https://fb.workplace.com/groups/755371733754414/posts/794025843514383/ Differential Revision: D83764096
nipung90
added a commit
to nipung90/torchrec
that referenced
this pull request
Oct 6, 2025
…s indices (meta-pytorch#3421) Summary: This validation would avoid issues like: https://fb.workplace.com/groups/755371733754414/posts/794025843514383/ Differential Revision: D83764096
nipung90
force-pushed
the
export-D83764096
branch
2 times, most recently
from
e402063 to
6a09c94
Compare
nipung90
added a commit
to nipung90/torchrec
that referenced
this pull request
Oct 7, 2025
…s indices (meta-pytorch#3421) Summary: This validation would avoid issues like: https://fb.workplace.com/groups/755371733754414/posts/794025843514383/ Differential Revision: D83764096
…s indices (meta-pytorch#3421) Summary: This validation would avoid issues like: https://fb.workplace.com/groups/755371733754414/posts/794025843514383/ Differential Revision: D83764096
nipung90
force-pushed
the
export-D83764096
branch
from
6a09c94 to
8b1a5ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This validation would avoid issues like: https://fb.workplace.com/groups/755371733754414/posts/794025843514383/
Differential Revision: D83764096