Add PALS/PBS environment support #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Add support for automatically detecting rank and world size when running in PALS (Parallel Application Launching System) environments, commonly used with PBS workload managers. Key changes: * Implement `query_pals_ranksize` to resolve rank/size from PALS/PBS env vars. * Add logic to calculate world size using `PBS_NODEFILE` and `PALS_LOCAL_SIZE` when `PALS_SIZE` is unavailable. * Add `count_file_lines` utility for parsing nodefiles with empty line handling. * Integrate PALS detection into `query_ranksize` bootstrap logic. * Update test helpers to support PALS environments. * Refactor rank/size validation to ensure non-negative rank and positive size.
std::istreambuf_iterator will not set the eofbit.
When counting newline characters with the std::istreambuf_iterator, files that don't ended with a newline were undercounted by one. This change should fix this issue.
pkourdis
force-pushed
the
feature/pals-support
branch
from
aea1bff to
5026d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for automatically detecting
rankandsizewhen running in PALS (Parallel Application Launching System) environments, commonly used with PBS workload managers.Key changes:
query_pals_ranksizeto resolve rank/size from PALS/PBS env vars.PBS_NODEFILEandPALS_LOCAL_SIZEwhenPALS_SIZEis unavailable.count_file_linesutility for counting the number of lines in a file with empty line handling.query_ranksizebootstrap logic.