Skip to content

[torchcodec] rename deprecated sampler #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[torchcodec] rename deprecated sampler #906

wants to merge 1 commit into from

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Sep 22, 2025

Differential Revision: D82962921

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 22, 2025
@facebook-github-bot
Copy link
Contributor

@scotts has exported this pull request. If you are a Meta employee, you can view the originating diff in D82962921.

NicolasHug
NicolasHug approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@NicolasHug NicolasHug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo lint issue. I assume that defining it as DEPRECATED_VideoClipSampler instead of the more conventional DeprecatedVideoClipSampler is a deliberate choice?

@scotts
Copy link
Contributor Author

scotts commented Sep 22, 2025

Deliberate, but not deeply considered. I want the name to be ugly and catch people's attention. Not adhering to normal naming standards, I think, helps do that.

@facebook-github-bot
Copy link
Contributor

@scotts has exported this pull request. If you are a Meta employee, you can view the originating diff in D82962921.

scotts added a commit to scotts/torchcodec that referenced this pull request Sep 23, 2025
@scotts @facebook-github-bot
[torchcodec] rename deprecated sampler (meta-pytorch#906)
a3eb450 
Summary:

Renaming the old, deprecated sampler to remove any doubt about its status. This code is not documented or part of our release.

Reviewed By: NicolasHug

Differential Revision: D82962921
@facebook-github-bot
Copy link
Contributor

@scotts has exported this pull request. If you are a Meta employee, you can view the originating diff in D82962921.

scotts added a commit to scotts/torchcodec that referenced this pull request Sep 24, 2025
@scotts @facebook-github-bot
[torchcodec] rename deprecated sampler (meta-pytorch#906)
b85a872 
Summary:

Renaming the old, deprecated sampler to remove any doubt about its status. This code is not documented or part of our release.

Reviewed By: NicolasHug

Differential Revision: D82962921
@facebook-github-bot
Copy link
Contributor

@scotts has exported this pull request. If you are a Meta employee, you can view the originating diff in D82962921.

@scotts @facebook-github-bot
[torchcodec] rename deprecated sampler (meta-pytorch#906)
87242f0 
Summary:

Renaming the old, deprecated sampler to remove any doubt about its status. This code is not documented or part of our release.

Reviewed By: NicolasHug

Differential Revision: D82962921
@facebook-github-bot
Copy link
Contributor

@scotts has exported this pull request. If you are a Meta employee, you can view the originating diff in D82962921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotts @facebook-github-bot @NicolasHug