net: framed: property testing FrameWrite is cancel safe #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

shayne-fletcher wants to merge 2 commits into meta-pytorch:main from shayne-fletcher:export-D80651806

+803 −63

Contributor

shayne-fletcher commented Aug 20, 2025

Summary: introduce proptest-based property tests for FrameWrite cancellation safety. add proptest dev/test deps; factor test harness (Throttled, SharedWriter, Gate, BudgetedWriter, budget_drips) into test_support; add generator sanity check (test_budget_sequence). new property test framewrite_cancellation_is_safe uses assert_cancel_safe_async to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806


          test_utils: new module cancel_safe

6be3d25

Differential Revision: D80626978

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 15ded3d to b7432f9 Compare

August 20, 2025 21:10

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

b7432f9

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

5682a41

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from b7432f9 to 5682a41 Compare

August 20, 2025 21:17

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

ad58a0d

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 5682a41 to ad58a0d Compare

August 20, 2025 21:23

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

b1afe22

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from ad58a0d to b1afe22 Compare

August 20, 2025 21:32

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

6dd5ca6

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from b1afe22 to 6dd5ca6 Compare

August 20, 2025 21:44

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 6dd5ca6 to 6339f9c Compare

August 20, 2025 21:52

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

6339f9c

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

b0c83f4

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 6339f9c to b0c83f4 Compare

August 20, 2025 22:56

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

c3d299f

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from b0c83f4 to c3d299f Compare

August 20, 2025 23:07

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from c3d299f to 75c1ca1 Compare

August 20, 2025 23:19

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

75c1ca1

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

6bc9b2c

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 75c1ca1 to 6bc9b2c Compare

August 20, 2025 23:32

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

615964e

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 6bc9b2c to 615964e Compare

August 20, 2025 23:47

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

d0e785d

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 615964e to d0e785d Compare

August 20, 2025 23:57

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher added a commit to shayne-fletcher/monarch-1 that referenced this pull request


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

1ad2505

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from d0e785d to 1ad2505 Compare

August 21, 2025 00:17


          net: framed: property testing FrameWrite is cancel safe (meta-pytorch…

b932afe

…#939)

Summary:
Pull Request resolved: meta-pytorch#939

introduce proptest-based property tests for `FrameWrite` cancellation safety. add proptest dev/test deps; factor test harness (`Throttled`, `SharedWriter`, `Gate`, `BudgetedWriter`, `budget_drips`) into `test_support`; add generator sanity check (`test_budget_sequence`). new property `test framewrite_cancellation_is_safe` uses `assert_cancel_safe_async` to cancel/restart send at arbitrary poll boundaries under fuzzed budget drip sequences, with shared gate+writer ensuring state persists. wrap in timeout to catch regressions; verify emitted frame matches body. behavior is unchanged; we now exercise cancel-safety as a theorem.

Differential Revision: D80651806

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D80651806

shayne-fletcher force-pushed the export-D80651806 branch from 1ad2505 to b932afe Compare

August 21, 2025 00:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported