Attribution API refactor: Update LLM attr typing + minor naming #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@craymichael has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84721071. |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 27, 2025
…-pytorch#1658) Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well. Differential Revision: D84721071
craymichael
force-pushed
the
export-D84721071
branch
from
8377240 to
6314afb
Compare
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 27, 2025
…-pytorch#1658) Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well. Differential Revision: D84721071
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 29, 2025
…-pytorch#1658) Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well. Differential Revision: D84721071
craymichael
force-pushed
the
export-D84721071
branch
from
6314afb to
1f3aa0c
Compare
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 29, 2025
…-pytorch#1658) Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well. Differential Revision: D84721071
Summary: Python 3.9 is EOL. Bump minimum version of Python to 3.10. Reviewed By: sarahtranfb Differential Revision: D85569426
…eta-pytorch#1657) Summary: Refactor LLMAttributionResult into an abstract base object that is generic. Create LLMAttributionResult as a concrete child with aliases for captum.attr API supporting legacy use. Changes support the refactor and enable more generalized use beyond logprob-based attribution. Differential Revision: D84721127
…-pytorch#1658) Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well. Reviewed By: jimshao1999 Differential Revision: D84721071
craymichael
force-pushed
the
export-D84721071
branch
from
1f3aa0c to
d5d0be1
Compare
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 30, 2025
…-pytorch#1658) Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well. Reviewed By: jimshao1999 Differential Revision: D84721071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update LLM attr definition to accommodate other typing considerations. Clean up some variable names as well.
Differential Revision: D84721071