Repository navigation
ci: run the test suite in release modes too - #139
Merged
Merged
Conversation
CI only ever ran Debug. The `u16` overflow in `parseCsi` that #130 fixes behaves differently either side of that line: Debug aborts the process, ReleaseFast wraps silently and hands the parser a garbage coordinate. Whichever way a bug lands, only one of the two builds shows it. Adds ReleaseSafe and ReleaseFast test jobs on Linux. They catch codegen and safety differences rather than platform ones, so there is no reason to multiply them across the OS matrix.
meszmate
force-pushed
the
chore/ci-release-tests
branch
from
August 14, 2026 04:19
fc86c18 to
3f3892d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 5 from the review.
CI only ever ran Debug. That matters: the
u16overflow inparseCsithat #130 fixes behaves differently on either side of the line — Debug aborts the process, ReleaseFast wraps silently and hands the parser a garbage coordinate. Whichever way a bug lands, only one of the two builds shows it.Adds ReleaseSafe and ReleaseFast test jobs. Linux only: these catch codegen and safety differences, not platform ones, so there is no reason to multiply them across the OS matrix.
Verified locally — ReleaseSafe, ReleaseFast and ReleaseSmall all pass on 0.16.0.