Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#major): Add orbit-bridge subgraph #1992

Merged
merged 53 commits into from
Dec 5, 2023

Conversation

@melotik melotik requested a review from jaimehgb May 3, 2023 15:31
@melotik melotik linked an issue Oct 2, 2023 that may be closed by this pull request
@tryouge tryouge changed the title Add Orbit Bridge Directory feat(#major): Add orbit-bridge subgraph Oct 2, 2023
@tryouge tryouge marked this pull request as ready for review October 2, 2023 21:47
@melotik melotik requested review from melotik and removed request for jaimehgb October 5, 2023 17:20
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things that should be quick fixes:

  • can you remove most of the code under common? None of it is actually used (aside from a few things in constants.ts)
  • Remove the generic and lending SDKs, those are not being used in this subgraph
  • In deployment.json there is already an orbit bridge configuration, can you move everything over to the orbit-bridge taxonomy instead of just orbit
  • we should be using the latest version of the price library (the prices folder), just need to copy/paste it in
    • Note: you will need to rebase to the latest master branch in order to grab the newest price library

Once these are fixed, can you redeploy everything and link to your subgraphs in the header comment, thanks. Otherwise the rest of the code lgtm. Once all of this is done I will approve and I will let Vincent know for following up :)

subgraphs/orbit/schema.graphql Outdated Show resolved Hide resolved
subgraphs/orbit/src/common/constants.ts Show resolved Hide resolved
deployment/deployment.json Show resolved Hide resolved
subgraphs/orbit/src/mappings/handlers.ts Outdated Show resolved Hide resolved
subgraphs/orbit/src/mappings/handlers.ts Outdated Show resolved Hide resolved
subgraphs/orbit/src/mappings/handlers.ts Show resolved Hide resolved
subgraphs/orbit/src/mappings/helpers.ts Outdated Show resolved Hide resolved
subgraphs/orbit/src/mappings/helpers.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, will follow up early next week @tryouge TY!

@melotik melotik merged commit 94cce12 into messari:master Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Orbit Bridge
2 participants