-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#major): Add orbit-bridge subgraph #1992
Conversation
… into orbit-bridge-add
… into orbit-bridge-add
… into orbit-bridge-add add orbit bridge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things that should be quick fixes:
- can you remove most of the code under common? None of it is actually used (aside from a few things in constants.ts)
- Remove the
generic
andlending
SDKs, those are not being used in this subgraph - In deployment.json there is already an orbit bridge configuration, can you move everything over to the
orbit-bridge
taxonomy instead of justorbit
- we should be using the latest version of the price library (the
prices
folder), just need to copy/paste it in- Note: you will need to rebase to the latest master branch in order to grab the newest price library
Once these are fixed, can you redeploy everything and link to your subgraphs in the header comment, thanks. Otherwise the rest of the code lgtm. Once all of this is done I will approve and I will let Vincent know for following up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, will follow up early next week @tryouge TY!
Add orbit bridge subgraph.
Staging Deployments: