Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump gpu-operator to v24.6.1 #2601

Closed
wants to merge 7 commits into from
Closed

feat: Bump gpu-operator to v24.6.1 #2601

wants to merge 7 commits into from

Conversation

mesosphere-ci
Copy link
Contributor

Upgrades the following apps to use version v24.6.1 of chart gpu-operator:

  • nvidia-gpu-operator from version 24.3.2 to 24.6.1

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/nvidia-gpu-operator labels Sep 1, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Sep 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/gpu-operator-v24.6.1

@coveralls
Copy link

coveralls commented Sep 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11071574302

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.557%
Totals Coverage Status
Change from base Build 11059957918: 0.0%
Covered Lines: 149
Relevant Lines: 289
💛 - Coveralls

@gracedo gracedo closed this Sep 4, 2024
@gracedo gracedo reopened this Sep 4, 2024
@gracedo gracedo mentioned this pull request Sep 4, 2024
Closed
@shubham2g shubham2g self-assigned this Sep 9, 2024
@shubham2g shubham2g added services/nvidia-gpu-operator ok-to-test Signals mergebot that CI checks are ready to be kicked off and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off services/nvidia-gpu-operator labels Sep 9, 2024
@shubham2g shubham2g force-pushed the chartbump/gpu-operator-v24.6.1 branch from d1fc58e to 3d85ccc Compare September 12, 2024 01:43
@shubham2g shubham2g added update-licenses signals mergebot to update licenses.d2iq.yaml open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed update-licenses signals mergebot to update licenses.d2iq.yaml open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/gpu-operator-v24.6.1

@tushar-wagh-nx tushar-wagh-nx force-pushed the chartbump/gpu-operator-v24.6.1 branch from dfb1947 to 141111e Compare September 20, 2024 09:58
@tushar-wagh-nx tushar-wagh-nx added ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/gpu-operator-v24.6.1

@gracedo gracedo requested a review from faiq September 23, 2024 19:11
mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
licenses.d2iq.yaml Outdated
@@ -385,7 +385,7 @@ resources:
- license_path: LICENSE
ref: ${image_tag}
url: https://github.com/stakater/Reloader
- container_image: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/cloud-native/gpu-operator-validator:v24.3.0-d2iq.0
- container_image: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/cloud-native/gpu-operator-validator:v24.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist, revert back to use of non-patched version: nvcr.io/nvidia/cloud-native/gpu-operator-validator:v24.6.1

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
licenses.d2iq.yaml Outdated
@@ -395,10 +395,10 @@ resources:
- license_path: LICENSE
ref: ${image_tag%-d2iq.0}
url: https://github.com/NVIDIA/gpu-operator
- container_image: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/k8s-device-plugin:v0.15.0-ubi8-d2iq.0
- container_image: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/k8s-device-plugin:v0.16.2-ubi8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to nvcr.io/nvidia/k8s-device-plugin:v0.16.2-ubi8

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
services/nvidia-gpu-operator/24.6.1/defaults/cm.yaml Outdated
@@ -14,7 +14,7 @@ data:
# Create a ConfigMap (default: false)
create: false
repository: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia
repository: nvcr.io/nvidia

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
services/nvidia-gpu-operator/24.6.1/defaults/cm.yaml Outdated
dcgmExporter:
enabled: true
version: 3.3.5-3.4.1-ubuntu22.04
version: 3.3.7-3.5.0-ubuntu22.04
validator:
repository: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/cloud-native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/cloud-native
repository: nvcr.io/nvidia/cloud-native

@mhrabovcin
Copy link
Contributor

@shubham2g @SandhyaRavi2403 some image references needs to be fixed in this PR.

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
services/nvidia-gpu-operator/24.6.1/defaults/cm.yaml
validator:
repository: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia/cloud-native
version: v24.3.0-d2iq.0
version: v24.6.1
operator:
repository: ghcr.io/mesosphere/dkp-container-images/nvcr.io/nvidia
version: v24.3.0-d2iq.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this image get also bumped? There is v24.6.1 version available.

@tushar-wagh-nx tushar-wagh-nx force-pushed the chartbump/gpu-operator-v24.6.1 branch from 141111e to 288853a Compare September 27, 2024 13:29
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
@mhrabovcin
Copy link
Contributor

mhrabovcin commented Oct 2, 2024 •
edited
Loading

@shubham2g lets close this PR and continue the work in #2692 which contains an important security fix.

@gracedo
Copy link
Contributor

gracedo commented Oct 2, 2024

superseded by #2692

@gracedo gracedo closed this Oct 2, 2024
@gracedo gracedo deleted the chartbump/gpu-operator-v24.6.1 branch October 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin left review comments

@faiq faiq Awaiting requested review from faiq

Assignees

@shubham2g shubham2g

Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/nvidia-gpu-operator size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mesosphere-ci @coveralls @mhrabovcin @gracedo @shubham2g @tushar-wagh-nx @d2iq-mergebot @SandhyaRavi2403