Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump grafana to 8.5.0 #2592

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions licenses.d2iq.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ resources:
notice_path: NOTICE.md
ref: v${image_tag}
url: https://github.com/grafana/grafana
- container_image: docker.io/grafana/grafana:11.1.0
- container_image: docker.io/grafana/grafana:11.1.5
sources:
- license_path: LICENSE
notice_path: NOTICE.md
Expand Down Expand Up @@ -82,7 +82,12 @@ resources:
- license_path: LICENSE.txt
ref: ${image_tag}
url: https://github.com/jimmidyson/configmap-reload
- container_image: ghcr.io/mesosphere/dkp-container-images/docker.io/kiwigrid/k8s-sidecar:1.25.3-d2iq.1
- container_image: ghcr.io/mesosphere/dkp-container-images/docker.io/kiwigrid/k8s-sidecar:1.26.1-d2iq.1
Copy link
Contributor

@mhrabovcin mhrabovcin Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist in the registry. Try using the quay.io/kiwigrid/k8s-sidecar:1.27.6

sources:
- license_path: LICENSE
ref: ${image_tag%-d2iq.1}
url: https://github.com/kiwigrid/k8s-sidecar
- container_image: ghcr.io/mesosphere/dkp-container-images/quay.io/kiwigrid/k8s-sidecar:1.26.1-d2iq.1
sources:
- license_path: LICENSE
ref: ${image_tag%-d2iq.1}
Expand Down Expand Up @@ -475,11 +480,16 @@ resources:
- license_path: LICENSE
ref: ${image_tag%-distro}
url: https://github.com/kiali/kiali
- container_image: ghcr.io/mesosphere/dkp-container-images/quay.io/kiwigrid/k8s-sidecar:1.26.1-d2iq.1
- container_image: quay.io/kiwigrid/k8s-sidecar:1.26.1
Copy link
Contributor

@mhrabovcin mhrabovcin Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try to use the newest one quay.io/kiwigrid/k8s-sidecar:1.27.6

sources:
- license_path: LICENSE
ref: ${image_tag%-d2iq.1}
url: https://github.com/kiwigrid/k8s-sidecar
- container_image: quay.io/kiwigrid/k8s-sidecar:1.27.4
Copy link
Contributor

@mhrabovcin mhrabovcin Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try to use the newest one quay.io/kiwigrid/k8s-sidecar:1.27.6

sources:
- license_path: LICENSE
ref: ${image_tag}
url: https://github.com/kiwigrid/k8s-sidecar
- container_image: quay.io/kubernetes_incubator/nfs-provisioner:v2.3.0
sources:
- license_path: LICENSE
Expand Down
8 changes: 4 additions & 4 deletions services/centralized-grafana/60.4.1/defaults/cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ data:
prometheus.kommander.d2iq.io/select: "true"
path: "/dkp/kommander/monitoring/grafana/metrics"
sidecar:
image:
registry: ghcr.io
repository: mesosphere/dkp-container-images/quay.io/kiwigrid/k8s-sidecar
tag: 1.26.1-d2iq.1
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a double sidecar yaml value.

Suggested change
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6

dashboards:
enabled: true
# label that the configmaps with dashboards are marked with
Expand Down
2 changes: 1 addition & 1 deletion services/centralized-kubecost/0.37.5/defaults/cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ data:
sidecar:
image:
repository: ghcr.io/mesosphere/dkp-container-images/docker.io/kiwigrid/k8s-sidecar
tag: 1.25.3-d2iq.0
tag: 1.26.1-d2iq.1
dashboards:
enabled: true
label: grafana_dashboard_kommander
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: grafana-logging-8.3.6-d2iq-defaults
name: grafana-logging-8.5.0-d2iq-defaults
namespace: ${releaseNamespace}
data:
values.yaml: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
kind: HelmRepository
name: grafana.github.io
namespace: kommander-flux
version: 8.3.4
version: 8.5.0
interval: 15s
install:
crds: CreateReplace
Expand All @@ -24,7 +24,7 @@ spec:
releaseName: grafana-logging
valuesFrom:
- kind: ConfigMap
name: grafana-logging-8.3.6-d2iq-defaults
name: grafana-logging-8.5.0-d2iq-defaults
targetNamespace: ${releaseNamespace}
---
apiVersion: v1
Expand Down
8 changes: 4 additions & 4 deletions services/kube-prometheus-stack/60.4.1/defaults/cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,10 @@ data:
path: /dkp/grafana
pathType: ImplementationSpecific
sidecar:
image:
registry: ghcr.io
repository: mesosphere/dkp-container-images/quay.io/kiwigrid/k8s-sidecar
tag: 1.26.1-d2iq.1
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6

dashboards:
enabled: true
label: grafana_dashboard
Expand Down
2 changes: 1 addition & 1 deletion services/kubecost/0.37.6/defaults/cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ data:
sidecar:
image:
repository: ghcr.io/mesosphere/dkp-container-images/docker.io/kiwigrid/k8s-sidecar
tag: 1.25.3-d2iq.1
tag: 1.26.1-d2iq.1

kubecostProductConfigs:
grafanaURL: "/dkp/kubecost/grafana"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: project-grafana-logging-8.3.5-d2iq-defaults
name: project-grafana-logging-8.5.0-d2iq-defaults
namespace: ${releaseNamespace}
data:
values.yaml: |
Expand All @@ -28,10 +28,10 @@ data:
pathType: ImplementationSpecific

sidecar:
image:
registry: ghcr.io
repository: mesosphere/dkp-container-images/quay.io/kiwigrid/k8s-sidecar
tag: 1.26.1-d2iq.1
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6

dashboards:
enabled: true
label: project_grafana_logging_dashboard
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
kind: HelmRepository
name: grafana.github.io
namespace: kommander-flux
version: 8.3.4
version: 8.5.0
interval: 15s
install:
crds: CreateReplace
Expand All @@ -23,5 +23,5 @@ spec:
retries: 30
valuesFrom:
- kind: ConfigMap
name: project-grafana-logging-8.3.5-d2iq-defaults
name: project-grafana-logging-8.5.0-d2iq-defaults
targetNamespace: ${releaseNamespace}
Loading