Adding support to mesos-role #770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brndnmtthws could you please review this? |
brndnmtthws
requested changes
Jan 7, 2017
| @@ -73,7 +73,7 @@ class MesosJobFramework @Inject()( | |||
|
|
|||
| def getReservedResources(offer: Offer): (Double, Double) = { | |||
| val resources = offer.getResourcesList.asScala | |||
| val reservedResources = resources.filter({ x => x.hasRole && x.getRole != "*" }) | |||
| val reservedResources = resources.filter({ x => x.hasRole && x.getRole != config.mesosRole()}) | |||
There was a problem hiding this comment.
This is actually the reverse logic. The original version of this method was correct.
There was a problem hiding this comment.
I can double check to see if this rejects * role offers, my cluster currently does not have any agents with * role
| @@ -36,7 +36,7 @@ class MesosTaskBuilder @Inject()(val conf: SchedulerConfiguration) { | |||
| .setName(name) | |||
| .setType(Value.Type.SCALAR) | |||
| .setScalar(Value.Scalar.newBuilder.setValue(value)) | |||
| .setRole("*") | |||
| .setRole(conf.mesosRole()) | |||
There was a problem hiding this comment.
This doesn't look right either.
There was a problem hiding this comment.
@brndnmtthws Resource was taking * as the hardcoded value. Now the conf value set in --mesos-role is used. I have tested in mesos using multiple chronos frameworks and various roles. My cluster now does not have * roles. Also using Resource.newBuilder we can only setRole. Its's not possible to add multiple roles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to single role. Default is still * role