Repository navigation
abseil-cpp: use dependency_names and format the port - #2974
Open
ContradNamiseb wants to merge 2 commits into
Open
ContradNamiseb wants to merge 2 commits into
ContradNamiseb wants to merge 2 commits into
Conversation
The port predates three sanity checks: the wrap used the name = dep provide form, meson_version was >=0.49.0 and the port was not formatted with meson format. List dependency_names in the wrap and override each name in the port, as ftxui did in dc9d1b5, require meson >=0.56.0, and format the port.
sanity_checks.py requires a new release whenever the port's files change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any change to the abseil-cpp port now fails
sanity_checks.py(see #2973), because the port predates three of its rules. This updates it:[provide]section listsdependency_namesinstead of using thename = depform, and the port callsmeson.override_dependency()for each of the 96 names, as ftxui did in dc9d1b5.meson_versiongoes from>=0.49.0to>=0.56.0.meson format.The provided dependencies are the same. This adds release 20250814.1-2; #2973 goes on top as 20250814.1-3.
AI disclosure
This PR was made with the help of AI and was verified by me.