Repository navigation
Conversation
robUx4
force-pushed
the
utf8proc-dllexport
branch
2 times, most recently
from
October 9, 2026 11:46
5535c64 to
7b1fdf1
Compare
…builds When UTF8PROC_STATIC is not set, on Windows builds the dllimport/dllexport is used for all public API's [^1]. This fails to link. UTF8PROC_STATIC needs to be set for that. And UTF8PROC_EXPORTS is a private define when building the DLL [^2][^3]. When using the DLL it should not be set. I submitted a patch to fix this in the CMake builds [^4]. Fixes mesonbuild#2957 [^1]: https://github.com/JuliaStrings/utf8proc/blob/4bfe012cb879a58a70715526e9db6a49486df571/utf8proc.h#L123 [^2]: https://github.com/JuliaStrings/utf8proc/blob/4bfe012cb879a58a70715526e9db6a49486df571/utf8proc.h#L129 [^3]: https://github.com/JuliaStrings/utf8proc/blob/4bfe012cb879a58a70715526e9db6a49486df571/CMakeLists.txt#L40 [^4]: JuliaStrings/utf8proc#370
robUx4
force-pushed
the
utf8proc-dllexport
branch
from
October 9, 2026 11:53
7b1fdf1 to
0ab47d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When UTF8PROC_STATIC is not set, on Windows builds the dllimport/dllexport is used for all public API's 1. This fails to link.
UTF8PROC_STATIC needs to be set for that.
And UTF8PROC_EXPORTS is a private define when building the DLL 23. When using the DLL it should not be set.
I submitted a patch to fix this in the CMake builds 4.
Fixes #2957
Footnotes
https://github.com/JuliaStrings/utf8proc/blob/4bfe012cb879a58a70715526e9db6a49486df571/utf8proc.h#L123 ↩
https://github.com/JuliaStrings/utf8proc/blob/4bfe012cb879a58a70715526e9db6a49486df571/utf8proc.h#L129 ↩
https://github.com/JuliaStrings/utf8proc/blob/4bfe012cb879a58a70715526e9db6a49486df571/CMakeLists.txt#L40 ↩
https://github.com/JuliaStrings/utf8proc/pull/370 ↩