Skip to content

Adds freetype compilation unit when toggled - #2799

Merged
stephanlachnit merged 1 commit into
mesonbuild:masterfrom
jUnG3:imgui-freetype
Oct 19, 2026
Merged

stephanlachnit merged 1 commit into
mesonbuild:masterfrom
jUnG3:imgui-freetype

Conversation

@jUnG3

@jUnG3 jUnG3 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Adds the misc/freetype/imgui_freetype.cpp compilation unit with its dependencies to the imgui lib when the option freetype is set.

that enables this kind of configuration in your project

dependency('imgui', default_options: ['freetype=true'])

Comment thread subprojects/packagefiles/imgui/meson.build
@bgilbert bgilbert added the needs fixes Pull request received review feedback and needs adjustments label Aug 10, 2026
@github-actions github-actions Bot removed the needs fixes Pull request received review feedback and needs adjustments label Sep 15, 2026
@jUnG3

jUnG3 commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Hi @stephanlachnit ,

Can you please review it again?

Now all test passes and I have implemented youre suggestions.

Comment thread subprojects/packagefiles/imgui/meson_options.txt Outdated
Comment thread subprojects/packagefiles/imgui/meson.build Outdated
@jUnG3
jUnG3 requested a review from stephanlachnit October 19, 2026 06:21
@stephanlachnit

Copy link
Copy Markdown
Collaborator

LGTM - can you squash the commits?

@eli-schwartz can we maybe add the squash and merge option back?

@jUnG3

jUnG3 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

LGTM - can you squash the commits?

@eli-schwartz can we maybe add the squash and merge option back?

Is squashed.

@stephanlachnit
stephanlachnit merged commit abfb7e0 into mesonbuild:master Oct 19, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants