Move support for .def files to DynamicLinker #15276
Merged
+28
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.def files are a linker concept, and they should not be shoehorned into the Compiler. Signed-off-by: Paolo Bonzini <[email protected]>
This adds support for DEF files to rust and removes some hasattr duck typing. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
added
OS:windows
Member
eli-schwartz
left a comment
eli-schwartz
left a comment
There was a problem hiding this comment.
This looks reasonable to me although it also looks like it should be a single commit. Hmm.
dcbaker
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.def files are a linker concept, and they should not be shoehorned into the Compiler. Making the compiler forward to DynamicLinker removes hasattr duck typing and gets Rust support (almost) for free.