Skip to content

Conversation

@xclaesse
Copy link
Member

No description provided.

@xclaesse xclaesse requested a review from jpakkane as a code owner October 27, 2025 16:46
@xclaesse xclaesse marked this pull request as draft October 27, 2025 16:50
@bonzini
Copy link
Collaborator

bonzini commented Oct 27, 2025

Nice, looks good (if this is merged first, I'll rebase #15168 which also has the padding fix).

@xclaesse
Copy link
Member Author

I noticed it breaks a tone of things, still WIP

A crate can depend on 2 different API versions of the same crate:
foo_1_dep and foo_2_dep.

Make sure a Dependency always has a version. When it's defined by a git
URL, or a path, the version could be omitted. Update once we fetched the
dependency's package.
@xclaesse xclaesse force-pushed the cargo-multi-version branch from 05f83b8 to 5ce7ed5 Compare October 27, 2025 20:53
@xclaesse xclaesse marked this pull request as ready for review October 27, 2025 20:53
It is required to have unique library names for rust_dependency_map to
work. In the case we have foo crate in multiple versions, we have to
make sure their .rlib file have a different name.
@xclaesse xclaesse force-pushed the cargo-multi-version branch from 5ce7ed5 to 76c81aa Compare October 27, 2025 21:41
Copy link
Collaborator

@bonzini bonzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better than the convention we have now.

@xclaesse xclaesse merged commit 44ce045 into mesonbuild:master Oct 28, 2025
32 checks passed
@xclaesse xclaesse deleted the cargo-multi-version branch October 28, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants