More cargo workspace work #15138
Merged
More cargo workspace work #15138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclaesse
force-pushed
the
cargo-workspace4
branch
3 times, most recently
from
ae7d35d to
66e54fd
Compare
|
I would also move env_set to a separate PR, and add a rustc_nightly feature option to opt into it (enabled = require nightly, disabled = never use nightly features which would be the default). I think most projects would want to compile the same code for nightly and non-nightly. I will review the first few patches today. |
bonzini
suggested changes
Oct 20, 2025
This was referenced Oct 20, 2025
Merged
xclaesse
force-pushed
the
cargo-workspace4
branch
from
66e54fd to
238268a
Compare
xclaesse
force-pushed
the
cargo-workspace4
branch
from
238268a to
3e7fedc
Compare
This allows keeping the manifest unmodified which is better practice for a parser. Previously some places had e.g. raw.setdefault(). It also fix some values: - BuildTarget.doc_scrape_examples is removed. It seems to be some experimental cargo feature, but I haven't found documentation that says it should be part of the manifest. It was also missing from raw manifest. - BuildTarget.edition does not default to 2015, it default to package's edition, which itself default to 2015. - bench value defaults to False for tests. - Dependency.path must be relative to its Cargo.toml location. If the value comes from the package it can be used as-is, but if it comes from workspace it must be made relative. - Library.name default to its package name with dash replaced with underscores.
xclaesse
force-pushed
the
cargo-workspace4
branch
from
3e7fedc to
0cb077f
Compare
bonzini
approved these changes
Oct 22, 2025
|
@bonzini thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.