Use toplevel Cargo.toml for feature resolution #15069
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
cargo-object
branch
4 times, most recently
from
54a06b6 to
d9eb84a
Compare
This was referenced Oct 2, 2025
bonzini
force-pushed
the
cargo-object
branch
2 times, most recently
from
e9b49dc to
294fcfa
Compare
bonzini
force-pushed
the
cargo-object
branch
6 times, most recently
from
38a59cc to
172a99f
Compare
rust.workspace() is the entry point for global feature resolution. It loads a Cargo.toml file and ensures that all dependencies will be built with the correct set of features. Fixes: mesonbuild#13404
Add features property to cargo.Interpreter to make default features configurable; customization of which features are enabled by default is triggered by rust.workspace(). Fixes: mesonbuild#14290
Signed-off-by: Paolo Bonzini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a skeletal implementation of #14639.
For now,
rust.workspace()returns an object with no methods but it triggers loading the toplevel Cargo.toml and using its[dependencies]section to prime feature resolution. For example, fixing the infamous sdroege/mandelbrot project only requires addingprior to the first invocation of
dependency.It is not meant to be a real implementation, but it shows why Cargo subprojects are currently broken and what logic is missing.
Fixes: #13404
Fixes: #14290