Skip to content

Conversation

@dnicolodi
Copy link
Member

No description provided.

@dnicolodi dnicolodi force-pushed the test-cmake-subproject branch 2 times, most recently from 47de165 to b1f6a08 Compare March 12, 2024 09:45
@rgommers rgommers added the tests label Mar 12, 2024
@dnicolodi dnicolodi added the dependency-bug A bug experienced by users of meson-python caused by a dependency, rather than in code in this repo label Mar 12, 2024
@rgommers
Copy link
Contributor

rgommers commented May 2, 2025

This is Draft until the upstream bugs are fixed, right?

@dnicolodi
Copy link
Member Author

It depends on your definition of draft PR 🙂. The PR is complete, but there is a bug in Meson that makes merging it not productive. I keep this open just to remember ourselves of the bug: I don't know cmake at all and I don't have the spare cycles required to investigate this.

@rgommers
Copy link
Contributor

rgommers commented May 2, 2025

👍🏼

In my book:

  • draft = "no need to review it"
  • non-draft & green = "ready for review & merge"

@dnicolodi
Copy link
Member Author

This was supposed to be non-draft and red, thus also not ready for review, probably. But it is so old that the test results have been flushed out. Setting it as draft now.

@dnicolodi dnicolodi marked this pull request as draft May 2, 2025 13:32
@dnicolodi dnicolodi force-pushed the test-cmake-subproject branch 3 times, most recently from 183ec0f to ece7218 Compare October 19, 2025 14:54
@dnicolodi dnicolodi force-pushed the test-cmake-subproject branch from ece7218 to 87db821 Compare October 28, 2025 17:17
@dnicolodi dnicolodi marked this pull request as ready for review October 28, 2025 17:18
@dnicolodi dnicolodi force-pushed the test-cmake-subproject branch from 87db821 to 68e93fc Compare October 28, 2025 19:55
@dnicolodi
Copy link
Member Author

This test does not really test much on the meson-python side, but it was useful to identify the problem on the Meson side, therefore I'm thinking to merge it to avoid the support for CMake subprojects to regress in the future. @rgommers, what do you think?

@rgommers
Copy link
Contributor

That seems like a good idea to me, covering this kind of thing with tests is helpful for meson-python users that rely on it.

Our CI doesn't check macOS + meson master, did you test that locally? If not I'll do that before merging.

@dnicolodi
Copy link
Member Author

Our CI doesn't check macOS + meson master, did you test that locally?

Yes, I tested that locally. On macOS the test passes also with older versions on Meson. The Meson fix is necessary only on Linux. However, I did not think that verifying this in CI was necessary. We can do that, if you think it is useful.

@dnicolodi dnicolodi force-pushed the test-cmake-subproject branch 6 times, most recently from ad5eca4 to 0b9d442 Compare October 30, 2025 20:29
@dnicolodi dnicolodi force-pushed the test-cmake-subproject branch from 0b9d442 to a978150 Compare October 30, 2025 20:35
@dnicolodi
Copy link
Member Author

I extended the test to run on macOS too. Merging.

@dnicolodi dnicolodi merged commit c109b1e into mesonbuild:main Oct 30, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-bug A bug experienced by users of meson-python caused by a dependency, rather than in code in this repo tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants