Refactoring of the components and app.vue #205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge and improve responsiveness in components/Device.vue
…dant and invalid styles, fix incorrect animate-bounce and optimize the classes usage in components/Firmware.vue
…nd invalid styles and optimize the classes usage in components/DeviceHeader.vue
|
@ReMatrixed is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
matvasenin
changed the title
|
Thanks for the PR. This is not something I want dynamically generated though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello PM's!
This PR removes invalid and redundant styles, replaces standalone svg elements with Heroicons (XMarkIcon and ChevronDownIcon), fixes incorrect usage of
format=".zip,.bin"and improves responsiveness. Affected files includeapp.vue,components/Device.vue,components/Firmware.vueandcomponents/DeviceHeader.vue.Also this PR adds filter tag autogeneration using
supportedVendorDeviceTagsfromresources.ts, which removes the need for manually adding tags toDevice.vue(for example, #193 can be easily merged without any changes inDevice.vue).