Update to a later meshtastic/rust and switch in available_ble_devices #528
+102
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajmcquilkin looks like systemic change fyi |
| tauri-plugin-log = { features = ["colored"] , version = "2" } | ||
| chrono = { version = "0.4.34", features = ["serde"] } | ||
| meshtastic = { git = "https://github.com/meshtastic/rust.git", rev = "6057294aa6cfa979033299f7f02cfe6ceafddeda", features = ["ts-gen", "bluetooth-le"] } | ||
| meshtastic = { git = "https://github.com/lukipuki/meshtastic-rust.git", rev = "71978de0121ed87c5953621d7fbe59f25f68fe13", features = ["ts-gen", "bluetooth-le"] } |
There was a problem hiding this comment.
aspecifically this part @ajmcquilkin
|
@barkincavdaroglu Thanks for looking through. for some background, this is a placeholder PR until meshtastic/rust#66 is merged, then this should be switched back to the official |
|
Can you try this new API instead meshtastic/rust#68 ? I'm also considering to swap out the tuple to a 2-field struct with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukipuki Thanks for working through the bluetooth discovery! This MR is just to keep track of these changes, hopefully we can get things merged up in
rustand this MR will need to be updated