Update Heltec_T190 and E290 #8768
Open
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mverch67
reviewed
Nov 27, 2025
| moduleConfig.canned_message.inputbroker_pin_a = ROTARY_A; | ||
| moduleConfig.canned_message.inputbroker_pin_b = ROTARY_B; | ||
| moduleConfig.canned_message.inputbroker_pin_press = ROTARY_PRESS; | ||
| moduleConfig.canned_message.inputbroker_event_cw = meshtastic_ModuleConfig_CannedMessageConfig_InputEventChar(28); |
Collaborator
There was a problem hiding this comment.
I'm not sure if it's a good idea to hard-code these pin values into the firmware. These input pins are configurable for a reason. If they are hard-coded they cannot be used for sth different (e.g. detection sensor).
Instead these values should be configured via app or CLI.
| * GPS pins | ||
| */ | ||
|
|
||
| #define GPS_L76K |
Collaborator
There was a problem hiding this comment.
Heltec vision master doesn't have a built-in GPS so the default should always be not present.
#define GPS_DEFAULT_NOT_PRESENT 1
| /* | ||
| * GPS pins | ||
| */ | ||
| #define GPS_L76K |
Collaborator
There was a problem hiding this comment.
Heltec vision master doesn't have a built-in GPS so the default should always be not present.
#define GPS_DEFAULT_NOT_PRESENT 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, I have updated the GPS and rotary encoder configuration for the Heltec-T190, and also added GPS adaptation support for the Heltec-E290.
Update Summary:
Testing Status:
Successfully tested GPS positioning functionality on actual Heltec-T190 hardware
Verified operation response of the rotary encoder on T190
Completed basic GPS module functionality testing for E290
[√] I have tested that my proposed changes behave as described.
[√] I have tested that my proposed changes do not cause any obvious regressions on the following devices: