Skip to content

Add compatibility with SAMD21 properly #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

zshzebra
Copy link
Contributor

@zshzebra zshzebra commented Apr 1, 2025

#ifdef ARDUINO_ARCH_SAMD
#define MT_WIFI_SUPPORTED
#endif

Currently, WiFi support is enabled solely based on ARDUINO_ARCH_SAMD macro,
which is too broad and causes linking errors on non-WiFi SAMD boards.

Instead of automatic detection, this change requires users to explicitly
enable WiFi support through a configuration flag. This prevents unexpected
linking errors on SAMD boards that don't have WiFi capabilities (like
Arduino Zero or other M0-based boards without WiFi hardware).

The change affects:

  • Removes automatic WiFi detection based on architecture
  • Users must now define MT_WIFI_SUPPORTED explicitly
  • Prevents linking errors on non-Feather M0 SAMD boards

Other Changes

  • Setup baud rate

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zshzebra zshzebra changed the title Remove USE_WIFI when on SAMD boards Add compatibility with SAMD21 properly Apr 15, 2025
@thebentern thebentern merged commit b1c62a1 into meshtastic:master Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants