[UI] Fix Visibility of Dark/Light Mode Toggle and Signup Button in Mobile View #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshansh <[email protected]>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ashparshp
reviewed
Jul 4, 2024
|
@Ashparshp please accept the pull request so it can get merged, or there are some changes that I need to make? |
Ashparshp
approved these changes
Jul 6, 2024
|
Hi @Ashparshp, I noticed that the PR is still marked as 'review required' even though you've approved it. Could you please confirm if everything has been completed on your end for the review process? Let me know if there's anything else needed to move it forward. Thanks! |
|
Thankyou @akshansh-modi for fixing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #203
It addresses the issue where the dark/light mode toggle and signup button were not visible in mobile view. The display property for these elements was set to none in mobile view. This PR ensures that both the dark/light mode toggle and signup button are now visible in both desktop and mobile views.
Signed commits