Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/malaviya parth/138 #140

Closed

Conversation

malaviya-parth
Copy link

@malaviya-parth malaviya-parth commented Aug 11, 2023

Notes for Reviewers

This PR fixes #138

  1. Changes the Twitter logo to new Twitter X logo
  2. Also has the Custom Scroll-Bar code

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 6956247
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/64e383afc6c4c0000872c93f
😎 Deploy Preview https://deploy-preview-140--meshery-play.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@malaviya-parth
Copy link
Author

Well Again as Preview failed here are the attached screenshots of the output:
Normal
image
On Hover
image

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malaviya-parth, please use svg, see the recent implementation on meshery.io meshery/meshery.io#1342

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malaviya-parth, the logo is not distinguishable on hover, please invert the colors, so that outlines are white when highlighted

Signed-off-by: Parth <[email protected]>
@Ghat0tkach
Copy link
Member

Hey @malaviya-parth
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@stale
Copy link

stale bot commented Oct 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 14, 2023
@stale
Copy link

stale bot commented Oct 28, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing to new Twitter X Logo
3 participants