Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign up button disappears when successfully signed up #108

Merged
merged 6 commits into from
Jul 2, 2023

Conversation

HetviSoni
Copy link
Contributor

Notes for Reviewers

This PR fixes #105
I have added a handleSignUpFormSubmit function in the parent component of Navigation and SignupForm (ie App) which handles the appearance/disappearance of the signup button in the header.

Meshery.CNCF.Playground._.Cloud.Native.Manager.for.Kubernetes.and.all.CNCF.projects.-.Google.Chrome.2023-05-11.13-19-21.mp4

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 87b380a
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/64a11fdceef8de0008594fe4
😎 Deploy Preview https://deploy-preview-108--meshery-play.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisiskaransgit
Copy link
Contributor

@HetviSoni The change is working as intended, resolve the merge conflicts and we are good to go

@thisiskaransgit thisiskaransgit self-requested a review May 15, 2023 15:14
@HetviSoni
Copy link
Contributor Author

@HetviSoni The change is working as intended, resolve the merge conflicts and we are good to go

Done

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thank you for your contribution 🎉

@leecalcote
Copy link
Member

Uh-oh, we have a merge conflict, @HetviSoni. Will you address this, please?

@Savio629 will you give this a review, too?

@HetviSoni
Copy link
Contributor Author

Uh-oh, we have a merge conflict, @HetviSoni. Will you address this, please?

@Savio629 will you give this a review, too?

Resolved👍

Copy link

@Savio629 Savio629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leecalcote
Copy link
Member

Uh-oh, a merge conflict has popped up

@HetviSoni
Copy link
Contributor Author

Uh-oh, a merge conflict has popped up

Resolved👍 :)

@HetviSoni
Copy link
Contributor Author

HetviSoni commented Jun 14, 2023

This pr has been open for a while now. It would be helpful if is merged or if any other changes are required, please suggest
@leecalcote @Savio629 @thisiskaransgit

Signed-off-by: Aaditya Narayan Subedy <[email protected]>
@asubedy asubedy merged commit 3bafe87 into meshery:master Jul 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After sign up issue
5 participants