-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sign up button disappears when successfully signed up #108
Conversation
Signed-off-by: HetviSoni <[email protected]>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@HetviSoni The change is working as intended, resolve the merge conflicts and we are good to go |
Signed-off-by: HetviSoni <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, thank you for your contribution 🎉
Uh-oh, we have a merge conflict, @HetviSoni. Will you address this, please? @Savio629 will you give this a review, too? |
Signed-off-by: HetviSoni <[email protected]>
Resolved👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Uh-oh, a merge conflict has popped up |
Signed-off-by: HetviSoni <[email protected]>
Resolved👍 :) |
This pr has been open for a while now. It would be helpful if is merged or if any other changes are required, please suggest |
Signed-off-by: Aaditya Narayan Subedy <[email protected]>
Notes for Reviewers
This PR fixes #105
I have added a handleSignUpFormSubmit function in the parent component of Navigation and SignupForm (ie App) which handles the appearance/disappearance of the signup button in the header.
Meshery.CNCF.Playground._.Cloud.Native.Manager.for.Kubernetes.and.all.CNCF.projects.-.Google.Chrome.2023-05-11.13-19-21.mp4
Signed commits