Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release tag function to work with alphanumeric tags w/signoff #557

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Jougan-0
Copy link
Contributor

@Jougan-0 Jougan-0 commented Aug 11, 2024

Description
The old function only works for numeric values and sort them. This function sorts tags based on release time rather than tag number.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Jougan-0
Copy link
Contributor Author

meshery/meshery#11598

@leecalcote
Copy link
Member

@Jougan-0 where did we land on this approach?

@Jougan-0
Copy link
Contributor Author

@Jougan-0 where did we land on this approach?

I was working solely on the migration and fixing bugs of the v1beta1 pr now that's done I'll head to this issue.

@leecalcote
Copy link
Member

@Jougan-0 thank you. I'll put the k6 model to use immediately, when this is completed.

Copy link
Contributor

@hamza-mohd hamza-mohd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a decision arrived at in terms of when to incorporate consideration of release date vs. tag numbering?

Copy link
Contributor

@hamza-mohd hamza-mohd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliminated merge conflicts.

Signed-off-by: Lee Calcote <[email protected]>
@Jougan-0
Copy link
Contributor Author

Jougan-0 commented Sep 4, 2024

Was a decision arrived at in terms of when to incorporate consideration of release date vs. tag numbering?

Nope haven't given it a thought again, this needs a revisit later this week if we don't stuck on Kanvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants