-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename pattern
to design
command in mesheryctl
#10603
Conversation
Signed-off-by: Aadhitya A <[email protected]>
pattern
to design
command in mesheryctl
Syncing with master. |
@alphaX86 are the checklist in the PR description up-to-date ? Have you performed the testing? // @RipulHandoo |
Signed-off-by: Aadhitya A <[email protected]>
@lekaf974, you might like to offer review on this PR. |
Signed-off-by: Aadhitya A <[email protected]>
🚀 Preview for commit da949ee at: https://66177fc7d2eb21462f381180--meshery-docs-preview.netlify.app |
Signed-off-by: Aadhitya A <[email protected]>
🚀 Preview for commit 8edfa1c at: https://66178e53a5c6bf51632114c5--meshery-docs-preview.netlify.app |
🚀 Preview for commit f22186a at: https://661792bbe2505556cdf25ffd--meshery-docs-preview.netlify.app |
🚀 Preview for commit be65353 at: https://6617b87dd731856ffd34ab3f--meshery-docs-preview.netlify.app |
🚀 Preview for commit 7209cd7 at: https://6617bb7bd2eb21799437ea93--meshery-docs-preview.netlify.app |
Signed-off-by: Aadhitya A <[email protected]>
🚀 Preview for commit 249b56f at: https://6617c1fbe4aa377f710ae663--meshery-docs-preview.netlify.app |
Signed-off-by: Aadhitya A <[email protected]>
🚀 Preview for commit 9a64556 at: https://6617c59f3809227db6ba47d8--meshery-docs-preview.netlify.app |
🚀 Preview for commit a3be89d at: https://661bc0b99f80c443ac3260d7--meshery-docs-preview.netlify.app |
Signed-off-by: Aadhitya A <[email protected]>
🚀 Preview for commit 83e9f87 at: https://661becf6740ddc7ef1de1a19--meshery-docs-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff here, @alphaX86. Will you confirm that each of the GitHub workflows (https://github.com/meshery/meshery/tree/master/.github) that reference mesheryctl pattern
have been updated as well?
Please consider this GitHub Action, too:
Great checklist, @alphaX86 |
@alphaX86, were you able to verify these and upgrade them? |
Sure taking a look |
Resyncing PR... |
Signed-off-by: Aadhitya A <[email protected]>
@@ -1,3 +1,3 @@ | |||
pattern file converted to pattern file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does pattern ok here or need to be rename to design ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took time to check and LGTM also I am not involve from enough time to be sure there are nothing that missing
@alphaX86 how are we doing on this diligence? --> #10603 (review) |
PR staled. Reopening a new one with synced changes |
Signed-off-by: Aadhitya A <[email protected]>
Notes for Reviewers
This PR fixes #10592
PR in progress! Please don't merge!Ready for review!Checklist:
pattern
in both tests as well as real usage (in progress)Signed commits