Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the icon collection for Helm plugin #1917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhushan354
Copy link

@bhushan354 bhushan354 commented Oct 2, 2024

Description

This PR fixes #
#1915

Notes for Reviewers
I have implemented the basic structure necessary to add the new extension on the meshery.io/extensions/ page. However, the content displayed in the pop-up still needs to be updated, and the light theme also requires modifications.

image

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Oct 2, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 1fdd6e0
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66fd55a3743fa20008368350
😎 Deploy Preview https://deploy-preview-1917--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

@bhushan354 Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@vishalvivekm
Copy link
Member

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when the site visitor is using light mode?

@leecalcote
Copy link
Member

What happens when the site visitor is using light mode?

@bhushan354?

@bhushan354
Copy link
Author

@leecalcote I’m still working on it. Also, I wanted to ask why the changes I made to the code, like the UI updates, aren't reflecting on localhost.

@bhushan354
Copy link
Author

i am having this problem from many days

@leecalcote
Copy link
Member

Exclude —incremental and —livereload from your build command.

@bhushan354
Copy link
Author

bhushan354 commented Nov 3, 2024

Meshery.io.mp4

@leecalcote I've excluded --incremental and --livereload from the build command, but the issue is still persisting.

@bhushan354
Copy link
Author

@leecalcote its working now and updating according to local changes , thanks for the help !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants