Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR for Unused CSS #1898

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

THEBOSS0369
Copy link

This PR fixes #896
This is the new PR for this PR #1880

Description
have added a script by which, now user don't have to change the file name in any file he/she just have to update the file name in the terminal.

I have added an unused component name-btn so after running this in the terminal, it will automatically delete all the unnecessary css component that is not in used. If you want to check any other file just change blog.scss to file you wanted to check anything-you-want.scss and it will done its work.

Run this in terminal
node check-unused-css.js blog.scss

This will be prompted in terminal after execution of the script

Success: The file 'blog.scss' was processed successfully. The output has been saved to './output/blog.scss' NOTE: ALL THE UNUSED CSS IS REMOVED FROM THE UPDATED FILE

Before running the script, i added an name-btn unused component in website
before testing

It is removed after execution of code
after testing

Note : The updated file will be saved in the output directory.

Notes for Reviewers
I found that many of the unused css styles are the ones that are used by pressing or hovering component like a button it has many styles like hovering OR on pressing different styles is used. so its style will be unused until the component is not in used.

Signed commits

  • Yes, I signed my commits.

leecalcote and others added 13 commits August 21, 2024 08:44
Signed-off-by: l5io <[email protected]>
Signed-off-by: THEBOSS0369 <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: THEBOSS0369 <[email protected]>
Signed-off-by: THEBOSS0369 <[email protected]>
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 3f4b067
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66e42ba66346f70009cf6031
😎 Deploy Preview https://deploy-preview-1898--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashparshp
Copy link

@THEBOSS0369, Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please consider adding it as an agenda item to the meeting minutes || meeting link.

@THEBOSS0369
Copy link
Author

THEBOSS0369 commented Sep 14, 2024

@THEBOSS0369, Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please consider adding it as an agenda item to the meeting minutes || meeting link.

Hey @Ashparshp ! This PR has already been discussed. Sudhanshu asked me to revert back the unnecessary changes from the previous PR and i wasn't able to revert back so i created a new One! Also the Previous Pr for this has been asked to reviewed from reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Consolidate duplicative and unused CSS
3 participants