Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meshery-design-embed extension to Meshery Extensions #1891

Merged
merged 5 commits into from
Sep 8, 2024

Conversation

Aviral0702
Copy link
Contributor

Description

This PR fixes #1890
Added Meshery design embed extension to meshery.io/extensions.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit aa180bc
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66dd8d6627514d0008707887
😎 Deploy Preview https://deploy-preview-1891--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Aviral Asthana <[email protected]>
@Ashparshp
Copy link

@Aviral0702, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

@vishalvivekm
Copy link
Member

@Ashparshp
We still see nothing once clicking on the logo in the extension modal, would you make sure to have opened an issue on this?
image

@vishalvivekm vishalvivekm merged commit a3b871a into meshery:master Sep 8, 2024
5 of 6 checks passed
@Ashparshp
Copy link

@vishalvivekm, #1883

@vishalvivekm
Copy link
Member

@vishalvivekm, #1883

Thanks.
I see @Aviral0702 has taken up the item. Do you have any update that you want to share today @Aviral0702 ? If yes, please add to agenda items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Meshmap Embedding Design feature on Extensions page
3 participants