Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI]: Meshery extension catalog modal image height fix #1882

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+170 −56
Open

[UI]: Meshery extension catalog modal image height fix #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ed0750
feat(UI): Meshery extension catalog modal image height fix
SAHU-01 Aug 19, 2024
9e27e25
Merge branch 'meshery:master' into master
SAHU-01 Aug 26, 2024
087f914
feat(UI):Fixing issue with snapshot image being streched
SAHU-01 Aug 26, 2024
30efeeb
Merge branch 'master' of https://github.com/SAHU-01/meshery.io
SAHU-01 Aug 26, 2024
2fcd6f8
Merge branch 'meshery:master' into master
SAHU-01 Oct 15, 2024
158c520
Merge branch 'meshery:master' into master
SAHU-01 Oct 22, 2024
f50f1b7
Merge branch 'meshery:master' into master
SAHU-01 Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 41 additions & 39 deletions _includes/extensions/modal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,61 +5,63 @@
align-items: center;
justify-content: flex-start;
}
.modal-image > img {

.modal-image>img {
width: 100%;
object-fit: contain;
}
</style>
<div id="open-modal" class="modal-window">
<!-- <div class="click-container"> -->
<div class="modal-content">
<div class="modal-image">
<button class="modal-close close">&times;</button>
<img class="image-class"
data-snapshot-light="{{extension.image}}"
data-snapshot-dark="{{extension.image}}"
src="{{extension.image}}"
onerror="this.src='/assets/images/meshery-color.svg'" loading="lazy" onclick="toggleFullScreenImage('{{ extension.extensionId }}')" />
</div>
<div class="vertical-line"></div>
<div class="modal-info">
<h2 class="modal-h2">
{{extension.name | upcase }}
<!--<a href="https://docs.meshery.io/extensions/{{extension.slug}}" target="_blank">{{extension.name | upcase }}
<div class="modal-content">
<div class="modal-image">
<button class="modal-close close">&times;</button>
<img class="image-class" style="height: 100%;" data-snapshot-light="{{extension.image}}"
data-snapshot-dark="{{extension.image}}" src="{{extension.image}}"
onerror="this.src='/assets/images/meshery-color.svg'" loading="lazy"
onclick="toggleFullScreenImage('{{ extension.extensionId }}')" />
</div>
<div class="vertical-line"></div>
<div class="modal-info">
<h2 class="modal-h2">
{{extension.name | upcase }}
<!--<a href="https://docs.meshery.io/extensions/{{extension.slug}}" target="_blank">{{extension.name | upcase }}
<img class="internal-link" src="{{site.baseurl}}/assets/images/buttons/external-link_black.svg"/>
</a>-->
</h2>
<h3 class="modal-h3">Description</h3>
<p class="content-toggle contentdata pre-white-space">{{extension.extensionInfo | url_decode | replace: '\\n', '<br/>' | replace: '\n', '<br/>' }}</p>
<!-- <span class="read-more" href="read-more.html">{% include expand.html %}</span> -->
</h2>
<h3 class="modal-h3">Description</h3>
<p class="content-toggle contentdata pre-white-space">{{extension.extensionInfo | url_decode | replace: '\\n',
'<br />' | replace: '\n', '<br />' }}</p>
<!-- <span class="read-more" href="read-more.html">{% include expand.html %}</span> -->

<h3 class="modal-h3">Features</h3>
<p class="content-toggle contentdata pre-white-space">{{extension.extensionCaveats | url_decode | replace: '\\n', '<br/>' | replace: '\n', '<br/>' }}</p>
<!-- <span class="read-more" href="read-more.html">{% include expand.html %}</span> -->
<div id="copy-url">
<div class="btn-class">
<div class="vertical-center" id="{{type.name}}">
<div class="btn-grp">
{% if {{extension.docsURL}} %}
<a href="{{extension.docsURL}}">
<button class="import-secondary" style="width: 7rem;">Learn More</button></a>
{% endif %}
<div class="btn-tooltip-grp">
<h3 class="modal-h3">Features</h3>
<p class="content-toggle contentdata pre-white-space">{{extension.extensionCaveats | url_decode | replace: '\\n',
'<br />' | replace: '\n', '<br />' }}</p>
<!-- <span class="read-more" href="read-more.html">{% include expand.html %}</span> -->
<div id="copy-url">
<div class="btn-class">
<div class="vertical-center" id="{{type.name}}">
<div class="btn-grp">
{% if {{extension.docsURL}} %}
<a href="{{extension.docsURL}}">
<button class="import-secondary" style="width: 7rem;">Learn More</button></a>
{% endif %}
<div class="btn-tooltip-grp">
{% if {{extension.URL}} %}
<a href="{{extension.URL}}">
<button class="import" style="width: 7rem;">Visit</button></a>
<a href="{{extension.URL}}">
<button class="import" style="width: 7rem;">Visit</button></a>
{% endif %}
</div>
</div>
</div>
</div>
</div>

</div>

</div>

<script src="{{ site.baseurl }}/assets/js/catalog-modal.js"></script>
<script src="{{ site.baseurl }}/assets/js/thumbnail-clickable.js"></script>

</div>

<script src="{{ site.baseurl }}/assets/js/catalog-modal.js"></script>
<script src="{{ site.baseurl }}/assets/js/thumbnail-clickable.js"></script>

<!-- </div> -->
</div>
Loading
Loading