Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected Malformatted YAML in Catalog Content #1879

Closed
wants to merge 1 commit into from
Closed

Corrected Malformatted YAML in Catalog Content #1879

wants to merge 1 commit into from

Conversation

shubhusion
Copy link

@shubhusion shubhusion commented Aug 18, 2024 •
edited
Loading

Description

This PR fixes #1877 the YAML parsing error in the file 29b94780-865c-460b-b852-cc5c31730561.md located in the _catalog/deployment directory. The error was due to Missing Indentation.

Notes for Reviewers

  • The YAML front matter in the affected file has been corrected with the correct indentation, resolving the parsing issue.
  • The build process for the meshery.io site should no longer produce errors related to this YAML file.

Signed commits

  • Yes, I signed my commits.

Feel free to adjust any details as needed before submitting!

@netlify Netlify
Copy link

netlify bot commented Aug 18, 2024 •
edited
Loading

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 312d281
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66c1d6468f66110008a11788
😎 Deploy Preview https://deploy-preview-1879--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amitamrutiya
amitamrutiya reviewed Aug 18, 2024
View reviewed changes
Copy link
Contributor

@amitamrutiya amitamrutiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way to fix this issue. This is an auto-generated file, not manually created. If you fix it this way, you'll end up having to correct this text manually every time. This file is generated by workflows or scripts, so you need to fix the workflow or script that generated it, I guess.

@shubhusion
Copy link
Author

This is not the right way to fix this issue. This is an auto-generated file, not manually created. If you fix it this way, you'll end up having to correct this text manually every time. This file is generated by workflows or scripts, so you need to fix the workflow or script that generated it, I guess.

@amitamrutiya Thank you for pointing that out. You're correct—manually fixing the auto-generated file would require repeated corrections every time it's regenerated. The more sustainable solution is to identify and address the issue within the workflow or script responsible for generating this file. I'll look into the script and make the necessary adjustments to ensure it generates the correct output moving forward. Thanks again for the insight!

@Ashparshp
Copy link

@shubhusion, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@shubhusion shubhusion closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitamrutiya amitamrutiya amitamrutiya left review comments

Assignees
No one assigned
Labels
area/catalog area/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Catalog] Meshery.io site builds with errors of malformatted YAML in catalog content
3 participants
@shubhusion @Ashparshp @amitamrutiya